Skip to content
Snippets Groups Projects

Add UTError to PrStoreUTHit, and update default properties

Merged Hangyi Wu requested to merge ut-add-uterror-bank into 2024-patches

Work with Moore!3268 (merged)

Corresponds to Allen!1607 (merged) (now part of Allen!1444 (merged))

Edited by Hangyi Wu

Merge request reports

Merge request pipeline #7465964 passed

Merge request pipeline passed for 51834236

Merged by Miroslav SaurMiroslav Saur 10 months ago (May 28, 2024 9:54pm UTC)

Pipeline #7465966 passed

Pipeline passed for 67e70d14 on 2024-patches

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Please do NOT use RawEvent directly as input. It makes it unneccessarily more complicated (and thus more error-prone) to properly configure Moore.

  • Hangyi Wu added 1 commit

    added 1 commit

    • 2d1c0e11 - Revert to RawBanks and allow specifying types

    Compare with previous version

  • Hangyi Wu added 1 commit

    added 1 commit

    • c4a007ce - fix: Geo -> ADC weighting, stripMax 128

    Compare with previous version

  • Rosen Matev added 1 deleted label

    added 1 deleted label

  • Rosen Matev changed target branch from master to 2024-patches

    changed target branch from master to 2024-patches

  • Hangyi Wu added 1 commit

    added 1 commit

    • c130a12b - fix: use separate switche instead of a vector for two bank types

    Compare with previous version

  • Hangyi Wu added 1 commit

    added 1 commit

    • 488bcc21 - fix: use separate switche instead of a vector for two bank types

    Compare with previous version

  • Hangyi Wu approved this merge request

    approved this merge request

  • Hangyi Wu resolved all threads

    resolved all threads

  • Hangyi Wu changed the description

    changed the description

    • Author Developer
      Resolved by Titus Mombaecher

      Dear @dovombru and @mveghel, I believe this Rec MR and the related Moore one is ready for merging. They add the UTError type to the PrStoreUTHit class, and the corresponding GPU counterpart is mentioned in the overview.

      There was a discussion in this thread about what is the best way to provide independent APIs for both UT and UTError types, and I believe we have reached a conclusion and this MR is essentially ready for merging. Could you please proceed with necessary testing and help merge it? Thank you!

      Edited by Hangyi Wu
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading