Fix beamSpotRcut in PatPV

Small fix to PatPV taking into account the beamline offset when calculating the radial distance to the beamline for the beamSpotRcut.

Without it large beam offsets (e.g. needed in reconstruction of MC since default is taken from DeVP on DetDesc) lead to no reconstructed vertices since wrong reference is used for distance calculation.

The options hlt2_v0_nobias_2.py have been used to test on a recent stack with platform x86_64_v3-centos7-gcc12+detdesc-opt and lcg version 104.

assigned to @nbehling

added RTA label

changed target branch from master to 2024-patches

changed the description

added 8 commits

• 5b3d7742 - Fix LED monitoring
• 20cc65f3 - Simplify the monitoring and enable the creation of multidimensional histograms
• 46761937 - Add functors to get the number of hits in regions of the muon stations
• 17a34469 - prefer Range
• 2bded296 - Add functors to retrieve LHC conditions
• f426e0a3 - Make sure that return types of Functors use Functors::Optional instead of std::optional
• 332b0591 - Suppress FastJet banner when OutputLevel is >= WARNING, fixes #417 (closed)
• 96d7c3e3 - Avoid creating a disabled tool on stop

Compare with previous version

Thanks for the fix! I think you want only PatPV to merge and not other files, no?

added 9 commits

• 5e250fb6 - Revert "Fix LED monitoring"
• f40f4657 - Revert "Simplify the monitoring and enable the creation of multidimensional histograms"
• dcbe59ec - Revert "Add functors to get the number of hits in regions of the muon stations"
• d4dc8f3d - Revert "prefer Range"
• 60a5822f - Revert "Add functors to retrieve LHC conditions"
• 25b366c9 - Revert "Make sure that return types of Functors use Functors::Optional instead of std::optional"
• 88d15ba0 - Revert "Suppress FastJet banner when OutputLevel is >= WARNING, fixes #417 (closed)"
• 91d72855 - Revert "Avoid creating a disabled tool on stop"
• 51cc46bf - Revert "Added UT Hit dumper for event display"

Compare with previous version

added 1 commit

• 1d1d1fb6 - Revert "Add functors to get the number of hits in regions of the muon stations"

Compare with previous version

added impacthigh priorityhigh labels

added PV finding bug fix labels

added 1 commit

• 71f090d9 - declare all variables when initialising

Compare with previous version

added 1 commit

• 0cf774cd - Fix formatting again

Compare with previous version

resolved all threads

/ci-test

assigned to @isanders

added ci-test-triggered label

• [2024-04-23 16:06] Validation started with lhcb-2024-patches-mr#197

assigned to @jonrob

resolved all threads