Draft: Adding a new code for Upstream and Muon tracks matching
The new VeloUTMuonBuilder code has been added to Tr/TrackTools
. That code is currently a copy of the VeloMuonBuilder one. Tuning for Upstream and Standalone muon tracks matching will be performed to improve the efficiency and the momentum resolution (if possible).
This MR is linked to Moore!3792 and LHCb!4659
An old MR was made to master !4006 (closed)
Edited by Ivan Cambon Bouzas
Merge request reports
Activity
added RTA label
mentioned in merge request Moore!3787 (closed)
- Resolved by Ivan Cambon Bouzas
- Resolved by Ivan Cambon Bouzas
- Tr/TrackTools/src/VeloUTMuonBuilder.cpp 0 → 100644
136 for ( auto& veloutstate : velouttrack->states() ) { aCopy->addToStates( *veloutstate ); } 137 aCopy->addToLhcbIDs( velouttrack->lhcbIDs() ); 138 for ( auto& muonstate : muontrack->states() ) { aCopy->addToStates( *muonstate ); } 139 aCopy->addToLhcbIDs( muontrack->lhcbIDs() ); 140 aCopy->firstState().setQOverP( qp ); 141 for ( auto& state : aCopy->states() ) { 142 state->setQOverP( qp ); 143 state->setCovariance( cov ); 144 } 145 aCopy->setFitStatus( LHCb::Track::FitStatus::Unknown ); 146 aCopy->setFitHistory( LHCb::Track::FitHistory::Unknown ); 147 aCopy->setType( LHCb::Track::Types::VeloMuon ); 148 149 float weight = weighteddistance; 150 // safe the new track in goodCopy if the distance between velo and muon is so far the closest 151 if ( weight < minweight ) { - Comment on lines +149 to +151
changed this line in version 14 of the diff
- Tr/TrackTools/src/VeloUTMuonBuilder_dev.cpp 0 → 100644
191 state->setCovariance( cov ); 192 } 193 aCopy->setFitStatus( LHCb::Track::FitStatus::Unknown ); 194 aCopy->setFitHistory( LHCb::Track::FitHistory::Unknown ); 195 aCopy->setType( LHCb::Track::Types::VeloMuon ); 196 197 float weight = weighteddistance; 198 // safe the new track in goodCopy if the distance between velo and muon is so far the closest 199 if ( weight < minweight ) { 200 minweight = weight; 201 infiniteMinWeight = false; 202 goodCopy = std::move( aCopy ); 203 } 204 } 205 206 if ( infiniteMinWeight ) continue; // -- nothing was found given that
infiniteMinWeight
is basically the same as!goodCopy
, why not use!goodCopy
instead ofinfiniteMinWeight
?Edited by Gerhard Ravenchanged this line in version 12 of the diff
mentioned in merge request Moore!3792
mentioned in merge request LHCb!4659
added 73 commits
- 9fac1bc5...e27e2eb9 - 63 earlier commits
- f97a3527 - Updated TrackFitMatchMonitor.cpp
- baaef1a0 - Prepare Rec v36r12
- 4531e920 - Adding VeloUTMuonBuilder classes for developing
- 65e92fe3 - adapt PRKalmanFilterTool
- 2a64e6fc - Correct iteration process in extrapolation of muon track to PV
- 236bf812 - Suppress printout from warning counter (follow up !4047 (merged))
- ca9f4579 - Fix charge for momentum determination with pT kick
- 1b365154 - get rid of GaudiHistoAlg in TrackPV2HalfMonitor
- 6506bb47 - Using LHCb::Algorithm::Traits
- 0361ef08 - Prepare Rec v36r12p1
Toggle commit list
Please register or sign in to reply