Skip to content

Cleanup HitManagers

Gerhard Raven requested to merge cleanup-hitmanagers into master

After Hlt!97 (merged), the decoding-on-demand is no longer used, and the hit managers can be simplified:

  • remove (now unused) 'prepareHitsInWindow'
  • remove (now unused) 'prepareHits(iterator)'
  • remove IStationSelector

and some additional modernization:

  • add range accessors (instead of two accessors for 'begin' and 'end') and use them in range-based for loops
  • prefer struct over class with only public methods/data
  • remove trivial destructors
  • remove trivial finalize methods
  • prefer stl algorithms over explicit loop
  • prefer emplace_back over push_back where appropriate
  • remove #if GCCXML
  • add 'final' qualifier where possible
  • prefer bitset<4> over array<bool,4>

Merge request reports