Adjusting pedestal subtraction

Adjusting pedestal subtraction to work with 4 asics and fixing data monitoring

added 1 commit

• c2b0530b - Adjusting Pedestal subtraction & CMS

Compare with previous version

Development of UT emulation package. Package base on TbUT software. Rewriting code to pedestal subtraction and CMS suppresion.

After skimming through this code I have few comments:

1. Delete .vscode files
2. ThresholdPlotter is never used anywhere?
3. UTEmuDataReader moved or created?
4. in UTEmuDataReader.cpp the decodeData function is too long
5. https://gitlab.cern.ch/lhcb/Vetra/blob/UTEmu_PedestalSubtraction/UT/UTEmu/src/UTEmuPedestalSubtractorAlgorithm.cpp#L90 this does not seem very informative
6. https://gitlab.cern.ch/lhcb/Vetra/blob/UTEmu_PedestalSubtraction/UT/UTEmu/src/UTEmuPedestalSubtractorAlgorithm.cpp#L137 this wool be mor readable in form of

auto pedestalFollowing = m_followingFactories[asic_num].createPedestalFollowing(m_followingOption);
m_pedestalFollowingPtrs[asic_num].reset(pedestalFollowing);

and this file could be written more clearly (split in to more functions). The indendation is wrong.

7. https://gitlab.cern.ch/lhcb/Vetra/blob/UTEmu_PedestalSubtraction/UT/UTEmu/src/UTEmuPedestalCalculator.cpp#L82 does it should be cout?

8. It is a good practice to use pre-incrementation instead of post incrementation.

9. commented-out code at https://gitlab.cern.ch/lhcb/Vetra/blob/UTEmu_PedestalSubtraction/UT/UTEmu/src/UTEmuRandomNoiseGenerator.cpp#L20

10. https://gitlab.cern.ch/lhcb/Vetra/blob/UTEmu_PedestalSubtraction/UT/UTEmuMonitoring/src/UTEmuDataMonitorAlgorithm.cpp#L186 if statement is nod needed

11. Should this hard-coded string be there? will it work ? https://gitlab.cern.ch/lhcb/Vetra/blob/UTEmu_PedestalSubtraction/UT/UTEmuStandalone/python/UTEmuStandalone/Configuration.py#L29

closed