Skip to content

Resolve "Refactor Registers, Constants and Argument Sanitization"

Szymon Kulis requested to merge refactor_registers_constants into master

This merge request is composed part of 4 smaller merge requests:

  • !1 (merged) :
    • splits lpgbt_constants to multiple classes: enums/pins/register_map
    • defines constants that are common for v0 and v1 and separates these specific for v0 and v1. This is only partially done for a few selected fields. It is more a demonstration of how I see it going forward. I wanted to limit the changes in this MR to minimize the review effort.
    • defines the new structure of register map (with built-in documentation and validation features)
    • adapts inheritance in all the classes to pick up correct constants
    • modifies lpgbt class to be compatible with new constants
  • lpgbt_rtl!654 - automatically generate new reg map for v0
  • lpgbt_rtl!653 - automatically generate new reg map for v1
  • lpgbt_tester!174 - modifies tests to be compatible with new constants

I was trying to not introduce any functional changes (besides the changes in scripts generating constants). All the changes should be purely "cosmetic".

Closes #1 (closed)

Edited by Szymon Kulis

Merge request reports