Fix clang warnings. (ControlTest-00-02-64)

	* Tagging ControlTest-00-02-64.
	* test/ProxyProviderSvc_test.cxx: Fix clang warnings.

2016-06-26  scott snyder  <snyder@bnl.gov>

	* Tagging ControlTest-00-02-63.
	* CMakeLists.txt: Fix declaration of StoreID test.

2016-06-20  scott snyder  <snyder@bnl.gov>

	* Tagging ControlTest-00-02-62.
	* Add testWriteAux.


Former-commit-id: dd7ec407

AtlasTest/ControlTest/CMakeLists.txt

-# $Id: CMakeLists.txt 754379 2016-06-13 03:05:17Z ssnyder $
+# $Id: CMakeLists.txt 757711 2016-06-26 13:59:12Z ssnyder $
 ################################################################################
 # Package: ControlTest
 ################################################################################
@@ -90,7 +90,7 @@ atlas_add_test( ClearStore_test
    ENVIRONMENT "JOBOPTSEARCHPATH=${_jobOPath}" )
 
 atlas_add_test( StoreID
-   SOURCES test/StoreID.cxx
+   SOURCES test/StoreID_test.cxx
    LINK_LIBRARIES TestTools StoreGateLib
    EXTRA_PATTERNS "^JobOptionsSvc +INFO|Service base class initialized successfully|DEBUG Property update for OutputLevel"
    ENVIRONMENT "JOBOPTSEARCHPATH=${_jobOPath}" )

AtlasTest/ControlTest/cmt/requirements

@@ -104,4 +104,3 @@ apply_pattern athenarun_test name="test_interactive_athena" \
 
 ## AthenaCommon/python unit-test
 apply_pattern declare_python_modules files="*.py"
-

AtlasTest/ControlTest/test/ProxyProviderSvc_test.cxx

@@ -122,7 +122,7 @@ void testReadPrivate(StoreGateSvc& rSG) {
   SGASSERTERROR((rSG.readPrivateCopy<Foo>("NotThere")).get() != 0);
   
   apFoo=rSG.readUniquePrivateCopy<Foo>("diskFoo");
-  assert(0 != &*apFoo);
+  assert(0 != apFoo.get());
   assert(floatEQ(0, static_cast<float>(apFoo->a()))); //check that our Foo is the def constr one
 
   //now test the situation in which we have a transient obj in the way
@@ -132,11 +132,11 @@ void testReadPrivate(StoreGateSvc& rSG) {
   assert(rSG.overwrite(CxxUtils::make_unique<Foo>(6.28), "privFoo").isSuccess());
   
   apFoo=rSG.readUniquePrivateCopy<Foo>("privFoo");
-  assert(0 != &*apFoo);
+  assert(0 != apFoo.get());
   assert(floatNEQ(6.28f, static_cast<float>(apFoo->a()))); //check that our Foo is a different one
   apFoo->setA(3.14);
   std::unique_ptr<Foo> bpFoo(rSG.readUniquePrivateCopy<Foo>("privFoo"));
-  assert(0 != &*bpFoo);
+  assert(0 != bpFoo.get());
   assert(&*bpFoo != &*apFoo); //two independent instances
   assert(floatNEQ(6.28f, static_cast<float>(bpFoo->a()))); 
   assert(floatNEQ(3.14f, static_cast<float>(bpFoo->a()))); 

AtlasTest/ControlTest/test/StoreGateSvcClient_test.cxx

@@ -350,6 +350,8 @@ int main() {
 
   testRecordObject(*pStore);
 
+  testWriteAux(*pStore);
+
   test_lock (*pStore);
 
   pStore->finalize().ignore();