Splitting these transform commands up into multiple lines makes it easier to
diff the commands when configuration is changed in the future.


Former-commit-id: 6b75d7a90c147bc82452a62c43a8989a6447ee25

`art.py compare grid` tries to compare 10 events in a file if the entries option
is not explicitly specified. This causes issues for shorter files. Explicitly
specify the `--entries` option for smaller HITS files. This should fix
ATLASSIM-3714.


Former-commit-id: 6a99702a579625242365de2e26b233bdcdb7725f

After discussion with experts it was determined that using `libimf` (Intel
Math Library) leads to different output even on different Intel architectures,
so the decision was taken to use `libm` for all Simulation ART jobs.

Removed the temporary `test_Sim_FullG4_ZPrime_QuasiStable-imf.sh` job and
also removed the use of histcomp from `test_Sim_FullG4_CalibrationHits_pions.sh`.

This should fix ATLASSIM-3663, ATLASSIM-3701 and ATLASSIM-3706


Former-commit-id: 551667b51995c6d5eaa27cc7f4f43d70a33bc0b5

Former-commit-id: 272b641e178fd3b30a5bba345c397d3a9ddd1be9

Some ART jobs were trying to compare more events than were present in the
output pool files. This was causing the regression tests on the pool files
to automatically fail.


Former-commit-id: 898af4ab9fb3a04f2b155dd9ddfeae51ef7cd19c

`m_randomEngine` is actually owned by the Random Number Service instance, so
should not be deleted elsewhere. I have added a comment to `ISF_FatrasTools/TransportTool.h`
to make the ownership clearer. This should fix the remaining crash seen in
ATLASSIM-3691 for ~"21.3".


Former-commit-id: bac0654b7ef60fe5070b5aa2a7dc35d7682282db

Former-commit-id: 34e65f45d435bf19f0199d09eb7e2c78a059f736

Former-commit-id: ea7d9dd1bac464d485f00f01d21f3258e185b363

Default initialize member variables of FastCaloSimCaloExtrapolation

Closes ATLASSIM-3650

See merge request atlas/athena!10785


Former-commit-id: 4a85a6899e59772e692feb8f3f17b5775ebc5059

ATLFASTIIF_PU now uses the "old" Fatras extrapolator due to important memory leaks and discontinued development of the "new" extrapolator.

Former-commit-id: 3b355242a0df364707dcb8002972a2b8274faaf0

This commit updates the syntax of the Simulation ART jobs in `SimCoreTests`
and `ISF_Validation` to save the status of each command run rather than
just the overall result.


Former-commit-id: 966bbea361671bea121e193118255eb71b5e180a

FastCaloSim: add classes for a smooth energy interpolation between neighbouring FastCaloSim parametrizations

Former-commit-id: 3f3cdf38ef8d2976ae521e9f30ebc75859ea8237

It was observed that some Tile Identifiers were returning sampling(layer) values
of 23 (which corresponded to an FCAL layer) this was causing problems in the
FastCaloSim V2 parameterization. Experts confirmed that the E4' Identifiers do not
fit with the usual Tile Identifier scheme and as such the sampling should be
hard-coded as `TileGap3` for such Identifiers. This should fix ATLASSIM-3601.


Former-commit-id: ffa67cf81f7a693062dbe15a9c13952b8fa0732b

When there is no input file, the `specialConfiguration` `SimFlag` will remain unset
therefore we should protect attempts to access it. This will fix ATLASSIM-3640


Former-commit-id: 002263e3733f5d02c6f18945d8141f4b821e629c

Former-commit-id: 3f8a648f52bb7950d061a71993f58a09756eb479

Former-commit-id: c79a7ed1b54b8c6125823d5437431afb2c67a0fb

Former-commit-id: de701f4c9e35b6261ff8585c3364c584721d9d58

Vakhtang Tsulaia authored 6 years ago and John Derek Chapman committed 6 years ago

ISF_Services: Comply with ATLAS naming conventions.

See merge request atlas/athena!10475

(cherry picked from commit 991fc7bb [formerly 209accd8d32274c3c413eb2b311e10e0455262e7])

609a9eee ISF_Services: Comply with ATLAS naming conventions.

Former-commit-id: d95f1170b83d5a2103ec47d2c8b26140be030f30

As this `GenParticleInteractingFilter` was updated in this merge
request added a unit test to confirm the expected behaviour now
and make sure that it doesn't change unexpectedly in the future.


Former-commit-id: 7ccc6047ea0833c802553eddac0b1a2a002e662f

In ATLASSIM-3578 it was found that Monopole particles were always
being vetoed from being passed to the simulation by the
`GenParticleInteractingFilter`. This commit extends the filter
to make it possible to classify additional non-standard PDG IDs
as interacting particles. This configuration is passed by the
`specialConfiguration` `SimFlag`.


Former-commit-id: e2598e5c59c96b69ebaddf69c8bf3101668c0ba1

ART Tests have been updated to only run for certain branch/project
combinations and have also been updated to save output root files
where useful.


Former-commit-id: 5899b8d6743cd4545a78fcb8adbba48665f282ea

Former-commit-id: e3b9e01f

Former-commit-id: b666c7449c28405a8e7457035342386c3c3b7aa3

* Required for custom dictionary generation while using this class outside of Athena with CINT


Former-commit-id: 216c0b5372aded9fa182274a54c383699aee1c00

Former-commit-id: 4235e32b80e1c55502e4198c0abc7d270636f09d

Former-commit-id: 409955efaf9d632bb35a0957b2554ac2f4c775d2

Former-commit-id: 8aca659f345fad30493e80baa210c7944a78ede9

Extra `TrkDetFlags` added that are needed for TRT hits when running
simulation jobs that use Fatras. Without the extra flags, only a
single TRT hit is recorded for each event.


Former-commit-id: e08a81fa1a678112f53cdaa454164a64e281ac0d

Former-commit-id: 2860da68be604a43dae231055fdfb61c6faca775

Adam Edward Barton authored 7 years ago and Atlas Nightlybuild committed 7 years ago

ISF_Services: Fix clang warnings.

See merge request atlas/athena!9606

(cherry picked from commit 73a581a4 [formerly 4c3ff3d0ea6c337695b967a6d530a96388f1156d])

5df310c4 ISF_Services: Fix clang warnings.

Former-commit-id: 461f5a6b87a863f287e91aa2daad60fddd8a8859

Special C10 cells are only read out by one PMT. This commit prevents TileFCS_StepInfoSD
from printing a warning when only one valid PMT identifier is returned for these cells.
See discussion in ATLASSIM-3601.


Former-commit-id: 7ffdf4a81554fa8f62a706bf42a4173b3eb0e216

This merge request synchronises the `TruthSvc` implementation in
~master and  ~"21.0". The principle changes are to make most methods
`const`. Two unused member variables have been deleted.


Former-commit-id: 42af6c829bdf19629e0cbee403aa2154c34b61d2

Former-commit-id: a172e84c144014ca6adbe73e09589b25e4db66e4

Initial commit of the TruthSvc unit test. To be expanded later.


Former-commit-id: 277ee960e4beca5ba533ad566fa057067f0e778b

Former-commit-id: 25ec21a7bda09482dec97625bf7da4b8b1e7cf55

It was found that calls to `ITruthIncident::parentParticleAfterIncident(...)`
may alter the output of subsequent calls to `ITruthIncident::parentParticle()`.
(Whether this should be the case is a separate issue to be followed up
elsewhere.)

The `TruthSvc` needed a couple of tweaks to make it robust against
this feature.  At the same time some of the logic was tidied up to
make it cleaner and more descriptive comments added in a couple of
places. See ATLASSIM-3313.


Former-commit-id: 147a1d97c669f1f5925dafd0b5d29433e3c88fa4

In ATLINFR-2296 it was noted that the CI attempts to run unit tests in
parallel.  As unit tests all run in the same directory this causes
problems if two tests try to write to the same file(s), as is the
case with the simualtion configuration unit tests, where `AtlasG4_tf`
and `Sim_tf` are run in mulitple configurations in different tests.

By using the `RESOURCE_LOCK` property it is possible to prevent
unit tests running the same job transform from running in parallel.
This allows all unit tests to succeed even when running in parallel
in local tests.


Former-commit-id: f4928e513e37e40231830179c6e4d20d58e6f273

Former-commit-id: b33c16a59ffba1851f556fd8deaffba4ba6766dc

Former-commit-id: 706f9b0c270264886e2d6ecedeec39601c63c54b

Former-commit-id: ba9bf9e3f90d4cba11596e98a1e66cfe4904171f