When running in AthenaMT, we only want to load the parametrization once.
For compatibilty with AthenaMT running the simulators themselves have to be AlgTools
though, so it makes sense to load the parametrization in a separate Service
which will then only be loaded once.

Making this change in the 21.0 branch initially, to make it easier to sweep changes to the parameterization
between 21.0 and master in the future.

Use only diff-root in regression test. Fixes ATLASSIM-4346

See merge request atlas/athena!28252

(cherry picked from commit 97ba4ff0)

7d75efe8 Use only diff-root in regression test. Fixes ATLASSIM-4346

Fixing typo pointed out in ATLASSIM-4367.

Fix regression test for test_AtlasG4_CavernBg_EVNT2TR.sh (ATLASSIM-4346)

See merge request atlas/athena!28102

Revert back change double to float for float TFCSLateralShapeParametrizationHitBase::get_sigma2_fluctuation(...)

In ATLMCPROD-7665 it was noted that merging of EVNT_TR files in AthenaMP jobs fails.
This is due to the fact that the EVNT_TR input/output file arguments are of type
`argPOOLFile` and so try to use the default approach for merging reconstruction outputs.
This merge request creates a new `argEVNT_TRFile` argument type where a specialized
merging configuration is used. This should fix ATLASJT-407.

scott snyder authored 5 years ago and Ahmed Hasib committed 5 years ago

 - Prefer preincrement to postincrement for iterators.
 - Pass strings by const reference, not by value.
 - Uninitialized class members.
 - Prefer initializing members in an initialization list.

FastCaloSim lateral fluctuation: add a special stochastic term for hadrons which adds linearly to the constant term

scott snyder authored 5 years ago and Ahmed Hasib committed 5 years ago

Should not depend on G4SimTPCnv.

Scott Snyder authored 5 years ago and Ahmed Hasib committed 5 years ago

Missing dependencies on AthenaBaseComps and CaloDetDescr.

Walter Lampl authored 5 years ago and Atlas Nightlybuild committed 5 years ago

added new art test for the QS simulation with the ExtraParticles package

See merge request atlas/athena!25938

(cherry picked from commit 91016016)

443296ca added new art test for the QS simulation with the ExtraParticles pagkace

Walter Lampl authored 5 years ago and Tadej Novak committed 5 years ago

Add a general 'ExtraParticle' package to add G4 particles from the PDGTABLE

See merge request atlas/athena!25476

(cherry picked from commit cf1e42a1)

05d3fa4e Add a general 'ExtraParticle' package to add G4 particles from the PDGTABLE
54491e7a Adds a check to only enter each pdgId once into the whitelist object in GenParticleSimWhiteList
9bdf8192 improved logging
f7693b6e move object inside the function
7f153ddf info -> debug

Adam Edward Barton authored 5 years ago and Atlas Nightlybuild committed 5 years ago

fix a bug with negative lifetimes in MesonsList.py

See merge request !25429

(cherry picked from commit 368bd98f)

c169eb6a fix a bug with negative lifetimes in MesonsList.py

Previously configuration-only unit tests of job transforms had
errors in their logs due to failed attempts to access the non-existant
output file. This change suppresses the problematic call in the case
that outputFileValidation is switched off. The change was made
in the individual transform files, so as not to alter the behaviour
for non-simulation transforms. It would be cleaner to tweak the
generateReport method of the `transform` module though.

After ATLASSIM-4225 it is clear that the stability of qball digitization output
needs to be monitored to confirm that the issues seen in 21.0 do not appear in
other branches.