Whether we are running a test-beam job or not should be known at
configuration time, so it is much more efficient to set a configurable
property at this point rather than checking whether we are using
a test beam geometry *every single step* in the pre-sampler. Part of
the changes for ATLASSIM-2643. (Does not change the output in my local tests.)


Former-commit-id: ffc9ec29d05010b853bca289ddb799d2e448ed46

Whether we are running a test-beam job or not should be known at
configuration time, so it is much more efficient to set a configurable
property at this point rather than checking whether we are using
a test beam geometry *every single step* in the pre-sampler. Part of
the changes for ATLASSIM-2643. (Does not change the output in my local tests.)


Former-commit-id: 94d71c38165cec8d43a49c10adf7610d5cb04c8a

Making a variables const where possible and tidying some syntax.


Former-commit-id: ad6fa0646125011fba809da00dc46837544d988f

As mentioned in	ATLASSIM-2643, lines using char* literals cause	short-lived
heap-allocations, harming simulation performance. This merge request aims
to mitigate this by making the strings in question static const.


Former-commit-id: 9680dee1dc3df5ad5ad7958a1fda116ddf76d85f

As mentioned in ATLASSIM-2643, lines using char* literals cause short-lived
heap-allocations, harming simulation performance. This merge request aims
to mitigate this by making the strings in question static const.


Former-commit-id: 9f80174247e061081f80592aac85f5429fa5de79

Initialize all member variables in the constructor.


Former-commit-id: 28472fb56aa828e9836e1fa8ce156aac7cef9e0f

Remove logically dead-code in `LArEMECChargeCollection`.


Former-commit-id: f7ab082c842de3998c7e35d79735c620652d5095

`LArBarrelPresamplerGeometry` used to include `PresParameterDef.icc`
in its `intitialize` method to set all the member variables defined
in `PresParameterDef.h`. Switched to using brace-initialization syntax
to initialize all of these variables directly in `PresParameterDef.h`
Default initialized all remaining variables in `LArBarrelPresamplerGeometry.h`
for consistency. Some member variables are set properly during the
`initialize` method still though. Should fix Coverity Defect 115448.


Former-commit-id: 34709691d12f35360c65c740fc92c3745877768f

The geometry calculator services in the `LArG4` packages (used in Simulation)
have been migrated use to the  `extends<AthService, ...>` pattern rather than
using the deprecated approach of specifying a	`queryInterface(...)` method
explicitly. The various interface classes have been migrated to use the
`DeclareInterfaceID` pattern rather than making the declaration explicitly.


Former-commit-id: 711c7ad13f72f8c38ac1e0f498e71c6a48a94980

The `LArG4ShowerLibSvc` (used in Simulation) has been migrated use to the
`extends<AthService, ...>` pattern rather than using the deprecated approach
of specifying a `queryInterface(...)` method directly. `ILArG4ShowerLibSvc`
has been migrated to use the `DeclareInterfaceID` pattern rather than making
the declaration directly. The use of `SvcFactory` and make `LArG4ShowerLibSvc`
constructor and destructor public rather than protected.


Former-commit-id: 39f300dc14dcdeebaa411ea9b97a17efcc9ba0b3

`HECGeometry` sets a number of its member variables in the `intitialize`
method based on values retrieved from the `HECDetectorManager`. Some of
these variables remained uninitialized in the constructor though.
Switched to using brace-initialization syntax to default-initialize all
member variables directly in `HECGeometry.h`. Some member variables are
set properly during the `initialize` method still though. Should fix
Coverity Defect 115452.


Former-commit-id: d22a7be11db273579739aaef474d64105c375ace

Former-commit-id: aa1867a5c4e92e90ad5baedbddd276cd38eed9bf

The `m_OOTcut` variable is already defined as a configurable property
of the `LArCalculatorSvcImp` base class, so it does not need to be
re-defined in the `LArFCALCalcuatorBase` derived class. In addition
rather than hard-coding the value during `LArFCALCalcuatorBase::initialize`
it can be set in the relevant `CfgGetter` methods in `LArG4FCALConfig.py`.
This should fix Coverity Defect 115443.


Former-commit-id: bca611904cd6721b365aa1c2e67a89fb20ce8bb4

`switch` statements used in the calculation of the `etaBin variable in
the `LocalGeometry::CalculateIdentifier` method contained dead code.
The calculation has been refactored slightly to remove the switch
statements. This should fix Coverity Defect 115128.


Former-commit-id: d2f5391eb7eb3b778b1497f19fcbc74ef3b9ce84

The `m_id_helper` member variable was uninitialized in the
`CalibSDTool` constructor. This change should fix Coverity Defect 118594.


Former-commit-id: 095c717a

These changes remove a lot of boiler-plate code from these base classes.


Former-commit-id: 2fe1abf0490d79d87a71a9efb9bab09dd1765a52

Former-commit-id: d488ebab95824692d9b2da074c2b196c2c343861

Former-commit-id: 0c8965fc6e3aa72f571ef62ee16e68968d1e7388

This new Algorithm can be used to merge multiple `CaloCalibrationHitContainer`
instances into a single instance. The initial use-case is for merging
multiple dead material `CaloCalibrationHitContainers` into one. See
ATLASSIM-3088.


Former-commit-id: 2260621a73a9b72239475654931cae5bbc6227e7

This is a bit of a kludge, but does split out the Dead Material hits
in volumes which are otherwise classified as Active/Inactive.


Former-commit-id: fdd3962dfaf8badf311bf453d2f1f3e74ec4cbe2

Former-commit-id: 1f46da1bc41e976b65da98bd2745c27862bf6ee4

Former-commit-id: 53452c710066adf636c60192d2718eda219fffb8

Former-commit-id: bd9e77eb21d2f31ea79f949d9fcb15c6e4f73920

James Beacham authored 7 years ago and Atlas Nightlybuild committed 7 years ago

Remove LArG4ShowerLibData package

See merge request atlas/athena!7103

(cherry picked from commit 3aecdfbc [formerly 74694280ce76899941af6424a6514b192d6b79cf])

e2704dbd Remove LArG4ShowerLibData package

Former-commit-id: 6c133cf733dadf16074b724cca162e37e3836832

This package existed only to install data files. The files were excluded from
git during the migration from svn and are picked up externally as of
ATLINFR-1648. This package now only installs broken symlinks and so isn't
needed.


Former-commit-id: e2704dbd84bb2986d8f13189a04a9a1a16c0c720

LArG4H6SD: Fix compilation warnings.

See merge request atlas/athena!7033

(cherry picked from commit dcf1bd37 [formerly 2450354f2b03b05fde41c922b21716efee0c1825])

b8859dbe LArG4H6SD: Fix compilation warnings.

Former-commit-id: 0ffdb742497912405e006ea8448d013c64b4bf08

Coverity warnings: members not initialized in ctor.


Former-commit-id: 1b562f4767c1a7ef0bfed6e6a1b76d740ee50950

Declare interface fixes 21.3

See merge request !4814


Former-commit-id: 53299a6c

Tamara Vazquez Schroeder authored 7 years ago and John Derek Chapman committed 7 years ago

Sweeping !5697 from master to 21.0.Update master to frozen shower changes which reduce memory footprint

See merge request !5943

Former-commit-id: 8fc1c6481879e78b7aeecc57616d75677a24dadf

`PyG4AtlasAlg` is now obsolete, so all usage should be removed from
job options. Also updated some other obsolete simulation syntax in
the affected job options files.


Former-commit-id: c29bd1c4

Move user actions to Geant4 base classes

See merge request !4134


Former-commit-id: a0862b0f

Former-commit-id: 27c06766bfbfb34037a9de66b7fdd89e50f23456

Former-commit-id: 7ef8362c6f5bc5fcb35f04e1c28c91c89a16733b

Former-commit-id: 427c5269581ee70faa34d0c693df669c6fd0aeb7

As part of the push to make simulation configuration more standard
the `_do_G4AtlasAlg` method (only run outside of ISF) which added
`G4AtlasAlg` to the `AlgSequence` has been removed. This means that
rather than being added when `PyG4AtlasAlg` is created `G4AtlasAlg`
has to be added explicitly to the `AlgSequence` in every set of
job options where `PyG4AtlasAlg` is added. Eventually `PyG4AtlasAlg`
will be removed from all these job options.


Former-commit-id: a7bf43099ab957bc15556b943eaf97700984518e

Former-commit-id: add6a54d

In ATLASSIM-3365 it was noted that the `LArHitContainer` names were
not being set properly as the LAr `SimpleSDTools` were using their
own `HitCollectionName` property rather than the standard
`OutputCollectionNames` property from the base class.


Former-commit-id: b846b2b2

This is transparent to the AtlasG4 setup, but if Geant4 is run within
the ISF, the sensitive detector HITS will go into separate *_G4 collections
and will be merged with the respective *_Fatras and *_FastCaloSim collections.


Former-commit-id: 7060e91d

Former-commit-id: d4e9ad46528e8e1a56bd671ebbc8c0dbf45bc908

Former-commit-id: 612eb28642fd46b878b4de8785f84f6727571ad2