Whether we are running a test-beam job or not should be known at
configuration time, so it is much more efficient to set a configurable
property at this point rather than checking whether we are using
a test beam geometry *every single step* in the pre-sampler. Part of
the changes for ATLASSIM-2643. (Does not change the output in my local tests.)


Former-commit-id: ffc9ec29d05010b853bca289ddb799d2e448ed46

Whether we are running a test-beam job or not should be known at
configuration time, so it is much more efficient to set a configurable
property at this point rather than checking whether we are using
a test beam geometry *every single step* in the pre-sampler. Part of
the changes for ATLASSIM-2643. (Does not change the output in my local tests.)


Former-commit-id: 94d71c38165cec8d43a49c10adf7610d5cb04c8a

Making a variables const where possible and tidying some syntax.


Former-commit-id: ad6fa0646125011fba809da00dc46837544d988f

As mentioned in	ATLASSIM-2643, lines using char* literals cause	short-lived
heap-allocations, harming simulation performance. This merge request aims
to mitigate this by making the strings in question static const.


Former-commit-id: 9680dee1dc3df5ad5ad7958a1fda116ddf76d85f

`LArBarrelPresamplerGeometry` used to include `PresParameterDef.icc`
in its `intitialize` method to set all the member variables defined
in `PresParameterDef.h`. Switched to using brace-initialization syntax
to initialize all of these variables directly in `PresParameterDef.h`
Default initialized all remaining variables in `LArBarrelPresamplerGeometry.h`
for consistency. Some member variables are set properly during the
`initialize` method still though. Should fix Coverity Defect 115448.


Former-commit-id: 34709691d12f35360c65c740fc92c3745877768f

The geometry calculator services in the `LArG4` packages (used in Simulation)
have been migrated use to the  `extends<AthService, ...>` pattern rather than
using the deprecated approach of specifying a	`queryInterface(...)` method
explicitly. The various interface classes have been migrated to use the
`DeclareInterfaceID` pattern rather than making the declaration explicitly.


Former-commit-id: 711c7ad13f72f8c38ac1e0f498e71c6a48a94980

Coverity warnings: members not initialized in ctor.


Former-commit-id: 1b562f4767c1a7ef0bfed6e6a1b76d740ee50950

Former-commit-id: d4e9ad46528e8e1a56bd671ebbc8c0dbf45bc908

Former-commit-id: b034464100b3a0d8d18431f65fb7aa53d7ebe975

This is part of the migration away from FADS, as discussed in ATLASSIM-2290.
Making these classes into AthServices means they can be configured in the normal
way and means that a lot of lazy initialization can be eliminated.


Former-commit-id: d4f062f50ef6fd940238573f6609e9a172c99620

Former-commit-id: 5bee4643ada1f4e295466fc80889a4ebd0e3d704

2016-03-23  scott snyder  <snyder@bnl.gov>

	* Tagging LArG4Barrel-00-01-35.
	* Avoid multiple divisions and divisions by constants.

	* Tagging LArG4Barrel-00-01-34.
	* Comply with ATLAS naming conventions.

2016-03-22  scott snyder  <snyder@bnl.gov>

	* Tagging LArG4Barrel-00-01-33.
	* src/LArBarrelPresamplerGeometry.cc (CalculateIdentifier): Fix a
	coverity warning.

LArG4Barrel/LArBarrelCalculator.h, LArG4Barrel/LArBarrelPresamplerCalculator.h - casting m_hdata.size() to an int to avoid warnings about int/unsigned int comparisons in identifier, time and energy methods. ATLASSIM-2422. Tag LArG4Barrel-00-01-32 (LArG4Barrel-00-01-32)

	* LArG4Barrel/LArBarrelCalculator.h,
	LArG4Barrel/LArBarrelPresamplerCalculator.h - casting
	m_hdata.size() to an int to avoid warnings about int/unsigned int
	comparisons in identifier, time and energy methods. ATLASSIM-2422
	* tag LArG4Barrel-00-01-32

14-10-2015  Zach Marshall <ZLMarshall@lbl.gov>

	* Removing string termination characters - no need.  ATLASSIM-1934
	* tag LArG4Barrel-00-01-31

03-10-2015 P. Strizenec <pavol @ cern.ch>

	* changing the LArVCalculator interface
	* tag LArG4Barrel-00-01-30

2015-08-31 G.Unal
        * LArMgr as default name for detectorName
        * tag LArG4Barrel-00-01-29
...
(Long ChangeLog diff - truncated)

	* Tagging LArG4Barrel-00-01-28.
	* src/LArCoudes.cc: Fix coverity warnings.

	* Tagging LArG4Barrel-00-01-27.
	* src/CryostatCalibrationCalculator.cc: Fix clang warning (remove
	unused variable).

	* Tagging LArG4Barrel-00-01-26.
	* LArG4Barrel/LArBarrelCalculator.h, src/LArBarrelCalculator.cc:
	Fix coverity warning; fix member names.

	* Tagging LArG4Barrel-00-01-25.
	* Fix coverity warnings.

	* LArG4Identifier by reference

src/PhysicalVolumeAccessor.cc - add assert.h header. Fix for G4 10 compatibility. ATLASSIM-453. Tag LArG4Barrel-00-01-23 (LArG4Barrel-00-01-23)