Former-commit-id: b0e5436cbc2612143926901d1d6e89c4df801f4a

Former-commit-id: e0355cc648a8307a9af20bb616647c0148fec7ce

Former-commit-id: e0c15196afe3a2e615dc9b75e5088c5c60697387

Former-commit-id: 74a0ba14d6672ed37122d5d6afdc854449cfdc48

Former-commit-id: 0ba4bddafc1273cfc841f94df4be15f143bdb5e2

Whether we are running a test-beam job or not should be known at
configuration time, so it is much more efficient to set a configurable
property at this point rather than checking whether we are using
a test beam geometry *every single step* in the pre-sampler. Part of
the changes for ATLASSIM-2643. (Does not change the output in my local tests.)


Former-commit-id: ffc9ec29d05010b853bca289ddb799d2e448ed46

Whether we are running a test-beam job or not should be known at
configuration time, so it is much more efficient to set a configurable
property at this point rather than checking whether we are using
a test beam geometry *every single step* in the pre-sampler. Part of
the changes for ATLASSIM-2643. (Does not change the output in my local tests.)


Former-commit-id: 94d71c38165cec8d43a49c10adf7610d5cb04c8a

Making a variables const where possible and tidying some syntax.


Former-commit-id: ad6fa0646125011fba809da00dc46837544d988f

As mentioned in	ATLASSIM-2643, lines using char* literals cause	short-lived
heap-allocations, harming simulation performance. This merge request aims
to mitigate this by making the strings in question static const.


Former-commit-id: 9680dee1dc3df5ad5ad7958a1fda116ddf76d85f

As mentioned in ATLASSIM-2643, lines using char* literals cause short-lived
heap-allocations, harming simulation performance. This merge request aims
to mitigate this by making the strings in question static const.


Former-commit-id: 9f80174247e061081f80592aac85f5429fa5de79

Initialize all member variables in the constructor.


Former-commit-id: 28472fb56aa828e9836e1fa8ce156aac7cef9e0f

Remove logically dead-code in `LArEMECChargeCollection`.


Former-commit-id: f7ab082c842de3998c7e35d79735c620652d5095

Former-commit-id: 80dc7df77e5727633ee74537144c133379dbef52

Former-commit-id: bf058fa6a8746ed896d674a0f7f92b91e2e50546

Former-commit-id: aad84ded5f7aad1a633fcc90b130060c8b0ccfae

Former-commit-id: 5c0ed559fb94b7f34963d92f7a4edab325234b2a

Adding protection for Run-1 data - Required by TCT - https://gitlab.cern.ch/atlas/athena/merge_requests/11198


Former-commit-id: 57d0f9b4b7a7237c18cf1b3fcfc75c0f9a9ca71f

This reverts merge request !11329

Former-commit-id: bdd29c5980f2afdfabdca2e8466d6e6788d29f49

Former-commit-id: 929be279c17e16b22e5cd591edeada7c11792c2c

Former-commit-id: f3a57ab7f1e4d6b9defed3c7a299471f4a1e3712

Former-commit-id: 60783da0861ad9d6276c25f1c1463dde5926ab16

Former-commit-id: 42a6f3e9c5eea7915fa6567a61b3ed3532782eb2

Functions initialize(), finalize(), bookHistograms(), fillHistograms(), procHistograms() moved to virtual override functions


Former-commit-id: 3a74c6938195e55c9401464d5fe596b267af843d

Former-commit-id: a1ea6ed6968ba0d727654e472bf0d1b2d70f432c

Former-commit-id: 707e7ab172d8867470a9dabbc0ce8034163541b2

Former-commit-id: 28d5e7e3e495277f8cbc9bcd6fd24a9cabcda229

Former-commit-id: 9d56bbf6163324466165cbbef66ea7af0ed4c9d3

Former-commit-id: 6637682c73d93a5ae80ea340e2a55fd65b8e7b36

Former-commit-id: 9ced3a23ce29d813243f85c5b8a21b9c0d2966fb

Former-commit-id: 456efbd85e401027ac6e1013ab12cccb414e26d0

Disable LAr alignment to avoid spurious warnings.


Former-commit-id: fe5c7ef61a6dbc332f88fe5d093db4c4ff9871d7

Former-commit-id: 2e9fefd4bc746e8f316d5dacebf67e7ebb1bf99b

Additional controls added to JO. Adjustments in how triggerDecisionTool is called. Algorithm for ATLLARONL-214


Former-commit-id: ce116330b8d46517348a5b1fbf8ef76ab48c75e0

Former-commit-id: b2b6ac33da1e23e99626e1de07db5d70bc2ab0cd

Algorithm in ATLLARONL-214 done and working offline. Minor adjustments and tests for proper output still needed. Code to be cleaned up.


Former-commit-id: 646dd0bf6b4bed089bcb53c0821ad68a0131e7ac

Former-commit-id: b3e4eae871218fc0ee405ee96ef2ac56ffb9d61e

Former-commit-id: 98bc07be846ab6ff24ae12679765cb8ad7235514

Former-commit-id: ffd65f86bfec3068314e0094e164f56faf612c0f

`LArBarrelPresamplerGeometry` used to include `PresParameterDef.icc`
in its `intitialize` method to set all the member variables defined
in `PresParameterDef.h`. Switched to using brace-initialization syntax
to initialize all of these variables directly in `PresParameterDef.h`
Default initialized all remaining variables in `LArBarrelPresamplerGeometry.h`
for consistency. Some member variables are set properly during the
`initialize` method still though. Should fix Coverity Defect 115448.


Former-commit-id: 34709691d12f35360c65c740fc92c3745877768f

The geometry calculator services in the `LArG4` packages (used in Simulation)
have been migrated use to the  `extends<AthService, ...>` pattern rather than
using the deprecated approach of specifying a	`queryInterface(...)` method
explicitly. The various interface classes have been migrated to use the
`DeclareInterfaceID` pattern rather than making the declaration explicitly.


Former-commit-id: 711c7ad13f72f8c38ac1e0f498e71c6a48a94980