Changes in response to code review for merge request https://gitlab.cern.ch/atlas/athena/merge_requests/8919
Major change in TFCSParametrizationBase to use the Gaudi MsgService for the logging output in Athena


Former-commit-id: 550788d6e466bef501ef3c13554e6eb513619324

Hide #pragma link C++ class XXX+; statements in header files from being seen during athena root dictionary generation


Former-commit-id: 314bafff2d5feacb2c6fdbb47073827c0e00c0e5

Former-commit-id: 3149f4e632f50f9c83fcf8c8e390583fde45c198

Former-commit-id: 298af39c54068415e108944a4fb072a754f0d338

Former-commit-id: 0dbfefebca2e49cf5f91c4df7236e52ee0dbd785

Former-commit-id: ba6f3159a962f06d9ac5b603acc41f8bfb225a68

Update for new simulation chain to be used in the internal validation and later also in the athena simulation


Former-commit-id: be7642452d1df0f44cf8018f52eb599d4dd14977

Former-commit-id: 11e1600fb379227057c7c6c453c53225b661f15d

Former-commit-id: f4d56b1b30cb995c934b6444d5177dad7fc838c2

Former-commit-id: a0f3efc34a5c0c3bbd5f62ff7247eb584c878cfa

Former-commit-id: 0c72409ab4308185be605c315327ad88c3ad8961

Former-commit-id: 9f02f518641e604a0ad06cec67b2581bac3bc8d2

Former-commit-id: 31267c2be06822961d0c0b71c31554f592317fab

Added the possibility to print `G4PrimaryVertex` objects as they are created
and switched an unprotected `cout` to be an verbose message.


Former-commit-id: 75729e7865115f3081acb12fbd9ed58c68bf2c4d

Former-commit-id: a061044a0be977831b132147dad3fe6089d42fe7

Former-commit-id: a6eb9607ae724258d27696151421417c17c23796

There was a copy-paste error in `skeleton.ESDtoNTUP_FCS.py`.


Former-commit-id: d47c02b76e12e4cf437d596a63598865191a10a9

Some G4 volumes are partly active and particle dead depending on
where in the volume the energy was deposited. This means that it
is perfectly possible to get a dead material `LArG4Identifier` for
some parts of an otherwise active volume. In this case we should
not issue a warning message as the `Identifier` generated from the
`LArG4Identifier` is expected to be invalid.


Former-commit-id: 49bfecc9756ce6b3548ef1c8ab0922d0cf13519d

Improving the warning messages from `TileFCS_StepInfoSD` requires
providing it with an instance of the `TileID` helper. This commit
adds extra information to the previous warning messages which will
then allow us to suppress the warnings in cases where a Tile Cell
is only read out by a single PMT.


Former-commit-id: 4c1a0f922fd05e30f876f8fa0e290d77ddf9bd4b

In a previous refactoring the protection against `Identifiers` with
no corresponding `CaloDetDescrElement` was lost from `LArFCS_StepInfoSD`.
This lead to seg faults at run-time when `get_element(Identifier)` returned
a `nullptr`. This should fix ATLASSIM-3574.


Former-commit-id: 6b182c134c8a5dd622aa22e9d56e76c7d2035bed

DigitizationTests: Comply with ATLAS naming conventions.

See merge request atlas/athena!8661

(cherry picked from commit 86da1d45 [formerly 78213b525c96a968f91616310ecfaef6dd85bf1c])

9cbadaf0 DigitizationTests: Comply with ATLAS naming conventions.

Former-commit-id: 3161c7e44598e77eae5486d4b598e10fb9a33e6f

ISF_PunchThroughTools: Comply with ATLAS naming conventions.

See merge request atlas/athena!8566

Former-commit-id: 1d4a5cf83ff84a22a6de5889230680c3cc1747d6

Former-commit-id: 6b5128db0c49cb1cd79a2343f30100ea2d540c01

Former-commit-id: 2179ab4d53d2602eba3a707317154f1b73d7dc97

Vakhtang Tsulaia authored 7 years ago and Atlas Nightlybuild committed 7 years ago

Gauginos: Comply with ATLAS naming conventions.

See merge request atlas/athena!8522

(cherry picked from commit e7dfcaac [formerly 30cd7ea9eb70b35f23c435d93807f5241017a1e3])

4037fd93 Gauginos: Comply with ATLAS naming conventions.

Former-commit-id: c5a21b7bb544b6c37966fba28260225cb477fd59

Vakhtang Tsulaia authored 7 years ago and Atlas Nightlybuild committed 7 years ago

FastCaloSimHit: Comply with ATLAS naming conventions.

See merge request atlas/athena!8501

(cherry picked from commit c4859495 [formerly 57c5c310f68e447b71ab1f5762a88064f955756e])

4a2012c4 FastCaloSimHit: Comply with ATLAS naming conventions.

Former-commit-id: d0fab63dc205a21ba58795b181aa7f6d43e0ce21

Vakhtang Tsulaia authored 7 years ago and Atlas Nightlybuild committed 7 years ago

RHadrons: Comply with ATLAS naming conventions.

See merge request atlas/athena!8507

(cherry picked from commit 81f8c3f8 [formerly b0430641cd01c7944bf459118d7a8adb7d118e52])

0141c9a7 RHadrons: Comply with ATLAS naming conventions.

Former-commit-id: a04f94c5a016ef42051c3b78e6d9d7ab9df4936d

Vakhtang Tsulaia authored 7 years ago and Atlas Nightlybuild committed 7 years ago

FastChainPileup: Comply with ATLAS naming conventions.

See merge request atlas/athena!8503

(cherry picked from commit 2f2392f7 [formerly a6c55ece])

e0772a95 FastChainPileup: Comply with ATLAS naming conventions.

Former-commit-id: 5746e0938dcd5565122fc0d54139a7ddf85022ab

Vakhtang Tsulaia authored 7 years ago and Atlas Nightlybuild committed 7 years ago

Quirks: Comply with ATLAS naming conventions.

See merge request atlas/athena!8505

(cherry picked from commit e5f1c9ac [formerly 3ba04003f7ea82fbcb857e8aa02281c43980cc18])

267c6b0a Quirks: Comply with ATLAS naming conventions.

Former-commit-id: 1924f25852f963f7ea86fb2080f9a6ec66468075

ISF_FastCaloSimSD: Comply with ATLAS naming conventions.

See merge request atlas/athena!8565

(cherry picked from commit 4758ae40 [formerly 200db8391f8a36d31db7c5e0f9cac8f7319da329])

f644d360 ISF_FastCaloSimSD: Comply with ATLAS naming conventions.

Former-commit-id: 5739d5a0ab1157449fba0248232adc5c89cd0c53

ISF_FatrasTools: Comply with ATLAS naming conventions.

See merge request atlas/athena!8568

(cherry picked from commit 37363d05 [formerly 1be654fd9f2c3352b6f4f69a6a14eb6a3e93c820])

cc96c9be ISF_FatrasTools: Comply with ATLAS naming conventions.

Former-commit-id: b23682093a75520b456b78de02614c962762ca0d

Gauginos: Comply with ATLAS naming conventions.

See merge request atlas/athena!8522

(cherry picked from commit e7dfcaac [formerly 30cd7ea9eb70b35f23c435d93807f5241017a1e3])

4037fd93 Gauginos: Comply with ATLAS naming conventions.

Former-commit-id: c3a365c60423174097e78055fad68db6606679b3

Former-commit-id: b1cc405ac8ea156a153f38deacbabc9af444bb8c

Charginos: Comply with ATLAS naming conventions.

See merge request atlas/athena!8504

(cherry picked from commit 06f75037 [formerly fc447cad])

7207c79c Charginos: Comply with ATLAS naming conventions.

Former-commit-id: b54f4b25ac6c619543e7dbb834613d4f67d399ef

During a discussion with the Geant4 experts about Geant4 UI commands
it was noted that the command `/geometry/navigator/check_mode true`
was being issued in `G4AtlasAlg` and `TransportTool`. Due to the point
in the initialization at which this is called it currently has no effect,
but if it were to be run it would greatly slow down simulation jobs
due to the extensive testing which it activates.

For this reason these calls are being dropped, to remove any possibility
of the code being activated in current/future production jobs.

See ATLSASIM-3454 for more discussion of how `G4UICommands` are used in
ATLAS simulation code.


Former-commit-id: 02b61a2426c21d04058d2035134fada217ba51a2

While working on ATLASSIM-3556 a minor configuration issue was found
in the `CfgGetter` method for the `VolumeDebuggerTool`.


Former-commit-id: 1332d9357c03097c7a1baf68ad61b9144e6a9e28

When we are running with quasi-stable particle simulation switched on it
is very useful to know what kind of interaction we are dealing with when
the `TruthSvc` comes to update the truth information. For this purpose the
interface of `ITruthIncident` has been extended to include an
`int interactionClassification() const` function. This returns zero in
the default implementation the function is then overloaded in
`Geant4TruthIncident` to use the the information from the current `G4Track`
to determine the nature of the interactions. There are four different
interaction classifications. Described as follows:

 - case 0: interaction of a particle without a pre-defined decay;

 - case 1: a particle with a pre-defined decay under-going a
           non-destructive interaction;

 - case 2: a particle with a pre-defined decay under-going a
           destructive interaction other than its pre-defined decay;

 - case 3: a particle under-going its pre-defined decay.

These will allow the TruthSvc to manipulate the `GenEvent` in different
ways in each case. This commit will help the work in ATLASSIM-3313.


Former-commit-id: cbb8cb5c71822c400bcc9565df9396a94fe7c4fc

Added an option to turn on/off the recording of G4 Hits when using ISF_HitAnalysis through the transform FCS_Ntup_tf.


Former-commit-id: f3d9afe721e7b98ab383c9cc9b97b228a4488c39

Former-commit-id: 64a5c27f49abf8389a74caacc5b2816822ce2854

Former-commit-id: 9d0093e0a97141476235a1da67a9dd081006a8ab