Petr Jacka authored 5 years ago and Ruth Pottgen committed 5 years ago

Using get_E_hit function in TFCSLateralShapeParametrizationFluctChain and TFCSLateralShapeParametrizationHitChain

Moved rnd definition to L46 to select same energy bin for single/multiple sliced energy param file creation

Adjust TFCSLateralShapeParametrizationHitChain to better work with large weights and stop enforcing normalization

When running in AthenaMT, we only want to load the parametrization once.
For compatibilty with AthenaMT running the simulators themselves have to be AlgTools
though, so it makes sense to load the parametrization in a separate Service
which will then only be loaded once.

Making this change in the 21.0 branch initially, to make it easier to sweep changes to the parameterization
between 21.0 and master in the future.

Revert back change double to float for float TFCSLateralShapeParametrizationHitBase::get_sigma2_fluctuation(...)

scott snyder authored 5 years ago and Ahmed Hasib committed 5 years ago

 - Prefer preincrement to postincrement for iterators.
 - Pass strings by const reference, not by value.
 - Uninitialized class members.
 - Prefer initializing members in an initialization list.