main-coverity-LArCellRec

main-coverity-LArCellRec

LArCalorimeter/LArCellRec/src/LArCelldeadOTXAlg.cxx

@@ -152,10 +152,14 @@ void LArCelldeadOTXAlg::buildMap(const EventContext& ctx, StatusCode& sc) const
       ATH_MSG_INFO("FEB " << m_onlineID->channel_name(febid) << " labelled as dead");
       std::vector<float> vector_of_multipliers;
       std::vector<uint32_t> vector_of_chans;
-      const unsigned nChans = m_onlineID->channelInSlotMax(febid);
+      const int nChans = m_onlineID->channelInSlotMax(febid);//may return -999
+      if (ATH_UNLIKELY(nChans < 0)) {
+        ATH_MSG_WARNING("LArCelldeadOTXAlg::buildMap : nChans<0");
+        continue;
+      }
       vector_of_multipliers.resize(nChans,0.0);
       vector_of_chans.resize(nChans,0xffffffff);
-      for (unsigned ch = 0; ch < nChans; ++ch) {
+      for (int ch = 0; ch < nChans; ++ch) {
         const HWIdentifier chid = m_onlineID->channel_Id(febid, ch);
         const Identifier id = oflCabling->cnvToIdentifier(chid);
         const IdentifierHash hashId = m_calo_id->calo_cell_hash(id);

LArCalorimeter/LArCellRec/src/LArCelldeadOTXAlg.h

 /*
-  Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2025 CERN for the benefit of the ATLAS collaboration
 */
 
 #ifndef LARCELLREC_LArCelldeadOTXAlg_H
 #define LARCELLREC_LArCelldeadOTXAlg_H
 
-
+#include "AthenaBaseComps/AthReentrantAlgorithm.h"
 #include "CaloInterface/ICaloCellMakerTool.h"
 #include "CaloDetDescr/ICaloSuperCellIDTool.h"
 #include "LArRawEvent/LArRawSCContainer.h"
 #include "LArRecEvent/LArDeadOTXFromSC.h"
-#include "StoreGate/ReadHandleKey.h"
-#include "StoreGate/ReadCondHandleKey.h"
-#include "AthenaBaseComps/AthAlgTool.h"
 #include "LArRecConditions/LArBadChannelCont.h"
 #include "LArCabling/LArOnOffIdMapping.h"
 #include "CaloDetDescr/CaloDetDescrManager.h"
-#include "AthenaBaseComps/AthReentrantAlgorithm.h"
 #include "StoreGate/WriteHandleKey.h"
+#include "StoreGate/ReadHandleKey.h"
+#include "StoreGate/ReadCondHandleKey.h"
+#include <mutex>
+#include <vector>
 
+class HWIdentifier;
 class LArOnlineID;
 class LArOnline_SuperCellID;
 class CaloCell_ID;