JetInputsMonitoring: Fix warnings with clang compilation.

JetInputsMonitoring: Fix warnings with clang compilation.

Binding references to temporaries in range-for.

Reconstruction/Jet/JetInputsMonitoring/src/ClusterMonitorAlgorithm.cxx

 /*
-  Copyright (C) 2002-2021 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration
 */
 
 #include "ClusterMonitorAlgorithm.h"
@@ -107,7 +107,7 @@ StatusCode ClusterMonitorAlgorithm::fillHistograms( const EventContext& ctx ) co
     nEMClusters = emclusters->size(); 
     fill("ClusterMonitorAllEMClusters", nEMClusters);
 
-    for (const auto& cluster : *clusters) {
+    for (const auto cluster : *clusters) {
       eta = cluster->eta();
       phi = cluster->phi();
       E   = cluster->e()/GeV;
@@ -148,7 +148,7 @@ StatusCode ClusterMonitorAlgorithm::fillHistograms( const EventContext& ctx ) co
     }
 
     // Repeat for EM clusters - Set monitored variables for this event
-    for (const auto& emcluster : *emclusters) {
+    for (const auto emcluster : *emclusters) {
       emeta = emcluster->eta();
       emphi = emcluster->phi();
       emE   = emcluster->e()/GeV;

Reconstruction/Jet/JetInputsMonitoring/src/PFOMonitorAlgorithm.cxx

 /*
-  Copyright (C) 2002-2021 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration
 */
 
 #include "PFOMonitorAlgorithm.h"
@@ -119,7 +119,7 @@ StatusCode PFOMonitorAlgorithm::fillHistograms( const EventContext& ctx ) const
     const static SG::AuxElement::ConstAccessor<int> acc_IsInDenseEnvironment("IsInDenseEnvironment");
     const static SG::AuxElement::ConstAccessor<float> acc_tracksExpectedEnergyDeposit("TracksExpectedEnergyDeposit");
 
-    for (const auto& pfo : *chpfos) {
+    for (const auto pfo : *chpfos) {
       pT  = pfo->pt()/GeV;
       eta = pfo->eta();
       phi = pfo->phi();
@@ -154,7 +154,7 @@ StatusCode PFOMonitorAlgorithm::fillHistograms( const EventContext& ctx ) const
 	      
     }
 
-    for (const auto& pfo : *nupfos) {
+    for (const auto pfo : *nupfos) {
       E   = pfo->e()/GeV;
       //some neutral particle flow FlowELement can have their energy set to exactly zero. Will get FPE if
       //try to calculate rapidity, so skip these.