Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
athena
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Michael Donald Hank
athena
Commits
e61d6cbc
Commit
e61d6cbc
authored
8 months ago
by
scott snyder
Committed by
scott snyder
4 months ago
Browse files
Options
Downloads
Patches
Plain Diff
DataQualityUtils: Fix cppcheck warnings.
Pass strings by const reference, not by value.
parent
d88835f0
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
DataQuality/DataQualityUtils/DataQualityUtils/StatusFlagCOOL.h
+3
-3
3 additions, 3 deletions
...uality/DataQualityUtils/DataQualityUtils/StatusFlagCOOL.h
DataQuality/DataQualityUtils/src/StatusFlagCOOL.cxx
+3
-3
3 additions, 3 deletions
DataQuality/DataQualityUtils/src/StatusFlagCOOL.cxx
with
6 additions
and
6 deletions
DataQuality/DataQualityUtils/DataQualityUtils/StatusFlagCOOL.h
+
3
−
3
View file @
e61d6cbc
/*
Copyright (C) 2002-202
3
CERN for the benefit of the ATLAS collaboration
Copyright (C) 2002-202
4
CERN for the benefit of the ATLAS collaboration
*/
#ifndef dqutilsStatusFlagCOOL_h
...
...
@@ -53,8 +53,8 @@ namespace dqutils {
virtual
~
StatusFlagCOOL
()
{};
// Methods of "interest". To insert a status flag you can use either ChannelId or ChannelName.
void
insert
(
cool
::
ChannelId
channelId
,
int
code
,
float
dfrac
,
float
thrust
,
std
::
string
tag_name
);
void
insert
(
std
::
string
channelName
,
int
code
,
float
dfrac
,
float
thrust
,
std
::
string
tag_name
);
void
insert
(
cool
::
ChannelId
channelId
,
int
code
,
float
dfrac
,
float
thrust
,
const
std
::
string
&
tag_name
);
void
insert
(
std
::
string
channelName
,
int
code
,
float
dfrac
,
float
thrust
,
const
std
::
string
&
tag_name
);
// Needed for the ROOT interface.
ClassDef
(
StatusFlagCOOL
,
0
)
// A class for modifying DQ info in the COOL database
...
...
This diff is collapsed.
Click to expand it.
DataQuality/DataQualityUtils/src/StatusFlagCOOL.cxx
+
3
−
3
View file @
e61d6cbc
/*
Copyright (C) 2002-202
3
CERN for the benefit of the ATLAS collaboration
Copyright (C) 2002-202
4
CERN for the benefit of the ATLAS collaboration
*/
// **********************************************************************
...
...
@@ -69,7 +69,7 @@ namespace dqutils {
void
StatusFlagCOOL
::
insert
(
cool
::
ChannelId
channelId
,
int
code
,
float
dfrac
,
float
thrust
,
std
::
string
tag_name
)
{
insert
(
cool
::
ChannelId
channelId
,
int
code
,
float
dfrac
,
float
thrust
,
const
std
::
string
&
tag_name
)
{
try
{
cool
::
RecordSpecification
spec
=
this
->
createSpec
();
coral
::
AttributeList
payload
=
this
->
createPayload
(
code
,
dfrac
,
thrust
,
spec
);
...
...
@@ -84,7 +84,7 @@ namespace dqutils {
void
StatusFlagCOOL
::
insert
(
std
::
string
channelName
,
int
code
,
float
dfrac
,
float
thrust
,
std
::
string
tag_name
)
{
insert
(
std
::
string
channelName
,
int
code
,
float
dfrac
,
float
thrust
,
const
std
::
string
&
tag_name
)
{
try
{
this
->
insert
(
this
->
getCoolFolder
()
->
channelId
(
channelName
),
code
,
dfrac
,
thrust
,
tag_name
);
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment