Scott Snyder authored 1 month ago and Adam Edward Barton committed 1 month ago

CaloCondBlobObjs: Fix test failure.

Test was failing because it was testing for a detection of an invalid blob
which isn't actually implemented in the code.

Probably wasn't noticed because this test used nopost.sh.  Changed to
noerror.sh.

Jean-Baptiste De Vivie De Regie authored 1 month ago and Duc Ta committed 1 month ago

Store subtracted calo cells instead of AllCalo when HI reco and cell subtraction

Scott Snyder authored 1 month ago and Adam Edward Barton committed 1 month ago

CaloCondBlobObjs: Fix unaligned writes.

Fix potential unaligned writes of 64-bit quantities, using 
CxxUtils::set_unaligned.
Fixes UB sanitizer warnings seen in the dbg build.

Sanya Solodkov authored 1 month ago and Duc Ta committed 1 month ago

Adding new scripts to read/write Lumi values from CALO COOL DB

Peter Van Gemmeren authored 1 month ago and Tadej Novak committed 1 month ago

Remove query from EventSelector

Pavol Strizenec authored 1 month ago and Jean-Baptiste De Vivie De Regie committed 1 month ago

LAr db fixes 6

Meisam Farzalipour Tabriz authored 1 month ago and Tadej Novak committed 1 month ago

use move instaed of copy

rewrite logic to avoid continue

Andrii Verbytskyi authored 1 month ago and Johannes Elmsheuser committed 1 month ago

Add neutral pions to  GetLCSinglePionsPerf.cxx

John Derek Chapman authored 1 month ago and Johannes Elmsheuser committed 1 month ago

Standardize the location of PackageName_entries.cxx

Twelve packages did not follow the convention of having the PackageName_entries.cxx
file in src/components/. This merge request updates those packages to match all
other packages in the repository.

Andrii Verbytskyi authored 1 month ago and Johannes Elmsheuser committed 1 month ago

Update GetLCSinglePionsPerf.cxx to find the first final state pion in the event record

Walter Lampl authored 1 year ago and Nuno Dos Santos Fernandes committed 2 months ago

CaloNoise: Add  method to get getEffectiveSigma by IdentiiferHash
(cherry picked from commit c6670c14)

Walter Lampl authored 7 months ago and Nuno Dos Santos Fernandes committed 2 months ago

CaloRec: Add option to create trigger decorations to Cluster Maker

See merge request atlas/athena!73946

(cherry picked from commit 83d116df)

    
Remove dependencies on unneeded ROOT components.  In particular, libHtml
no longer exists in 6.34.

Shaun Roe authored 3 months ago and Frank Winklmeier committed 3 months ago

main-cppcheck-CaloDetDescr

Scott Snyder authored 3 months ago and Jean-Baptiste De Vivie De Regie committed 3 months ago

CaloTrackingGeometry: Fix out-of-bounds vector access.

Fixes crash when built with -D_GLIBCXX_ASSERTIONS.

Scott Snyder authored 3 months ago and Jean-Baptiste De Vivie De Regie committed 3 months ago

CaloRec: Fix cppcheck warning.

nextCelIterEnd gets invalidated on erase().

Scott Snyder authored 3 months ago and Tadej Novak committed 3 months ago

CaloRec: Fix cppcheck warning.

nextCelIterEnd gets invalidated on erase().

Shaun Roe authored 3 months ago and Johannes Elmsheuser committed 3 months ago

Coverity defect CaloCondPhysAlgs

Mark Hodgkinson authored 3 months ago and Adam Edward Barton committed 3 months ago

Add pflow configuration to run on topotowers

Bertrand Martin Dit Latour authored 3 months ago and Jean-Baptiste De Vivie De Regie committed 3 months ago

CaloRec: be sure auxiliary variables get defined (cont'd)

Hello,

This MR is a follow-up of !75506, and attempts to silence the remaining warning seen in trigger ART tests (ATR-30429, ATLASRECTS-7180)
```
xAOD::AuxSelection WARNING Selected dynamic Aux atribute "CellLink" not found in the registry
```
It follows the same strategy, but as `CellLink` is not a cluster moment, it escaped !75506. I put the check in CaloTopoClusterMaker, hopefully that is an appropriate place.
The warning no longer appears with the suggested modification.

Cheers,
Bertrand

John Derek Chapman authored 3 months ago and Adam Edward Barton committed 3 months ago

Wrap calls to CaloCalibrationHit::particleID()/particleUID() in HepMC::barcode() and HepMC::uniqueID wrapper functions respectively

John Derek Chapman authored 4 months ago and Adam Edward Barton committed 4 months ago

Extend truth wrapper functions to work for CaloCalibrationHits

Suppress a cppcheck false positive about passing a parameter by value.

Frank Winklmeier authored 9 months ago and Tadej Novak committed 4 months ago

add a PileUpPretracking ProductionStep to set parameters with a prefix of Bkg_

See merge request atlas/athena!71844

List initialize members and ignore complicated macros.

In preparation for upcoming changes in the externals (ATLINFR-5446),
set the minimum required cmake version to 3.25.

Also fixes warnings about deprecated cmake versions in
cmake 3.31 (ATLINFR-5585).

Many of the "false positives" have been fixed in our current version of
cppcheck (2.16). Remove the suppression of these defects.

Denis Oliveira Damazio authored 4 months ago and Jiri Masik committed 4 months ago

LArFCalTowerBuilderTool : improve thread safety of look-up table building

Pavol Strizenec authored 4 months ago and Jean-Baptiste De Vivie De Regie committed 4 months ago

LAr HVlines  noise flag

John Derek Chapman authored 4 months ago and Jean-Baptiste De Vivie De Regie committed 4 months ago

CaloConfigFlags.py: Add missing flag expected by AthenaConfiguration_AllConfigFlagsTest_AOD_Full_ctest

Use ATH_MSG macros, remove unused functions, move properties to header.

Copy the entire CaloRecGPU package form the main branch to 24.0.

The explicit `extends2`, `extends3`, etc. classes are no longer required
and can be replaced by the variadic `extends`.