JiveXML: Silence clang warnings

Johannes Junggeburth authored 1 month ago and Johannes Elmsheuser committed 1 month ago

MuonR4 - Fix b-line calculation in geometry transcription & updates to the GeoModelTests

Scott Snyder authored 1 month ago and Johannes Elmsheuser committed 1 month ago

VP1Utils: Fix compilation warning.

Add using declaration to avoid warning about hidden handleShape overloads.
(Doesn't show up in standard builds due to the use of -isystem for GeoModel.)

Shaun Roe authored 2 months ago and Vakhtang Tsulaia committed 2 months ago

main-cppcheck-VP1TestSystems

Shaun Roe authored 2 months ago and Vakhtang Tsulaia committed 2 months ago

main-cppcheck_suppress-VP1VertexSystems

Shaun Roe authored 2 months ago and Walter Lampl committed 2 months ago

main-cppcheck-VP1Utils

Shaun Roe authored 2 months ago and Walter Lampl committed 2 months ago

main-cppcheck-VP1RawDataSystems

Shaun Roe authored 2 months ago and Walter Lampl committed 2 months ago

main-cppcheck_suppress-VP1VertexSystems

Shaun Roe authored 3 months ago and Frank Winklmeier committed 3 months ago

main-cppcheck-EventDisplayFilters

Fix pass-by-ref and potential nullptr deref.

Shaun Roe authored 3 months ago and Tadej Novak committed 3 months ago

main-cppcheck-EventDisplaysOnline

Frank Winklmeier authored 3 months ago and Johannes Elmsheuser committed 3 months ago

cppcheck: remove Qt from the list of default libraries

The `qt` cppcheck library defines macros that conflict with our code
base (e.g. `slots`). Remove it from the default list and require
packages to configure this where needed.

Vakhtang Tsulaia authored 3 months ago and Johannes Elmsheuser committed 3 months ago

VP13DCocktailChannel: fixed clang compiler error

Wrong placement of the maybe_unused attribute

Mostly pass and return-by-reference fixes.

Use `std::unique_ptr` for class members. Fixes cppcheck
noCopyConstructor defects.

The explicit `extends2`, `extends3`, etc. classes are no longer required
and can be replaced by the variadic `extends`.

Johannes Junggeburth authored 4 months ago and Adam Edward Barton committed 4 months ago

MuonCalib - Remove the wire sagging

Shaun Roe authored 5 months ago and Adam Edward Barton committed 5 months ago

main-coverity-EventDisplaysOnline

Dropping `GAUDI_V20_COMPAT` enables symbol visibility in Gaudi, i.e. the
`GAUDI_API` macro is no longer empty. This uncovered some misplaced ones
but in general we shouldn't be using these in athena as a client of
Gaudi.

Remove usage of deprecated service APIs (ATEAM-1020).

Scott Snyder authored 5 months ago and Adam Edward Barton committed 5 months ago

EventDisplaysOnline: Fix cppcheck warnings.

Prefer to pass strings/containers by const reference rather than value.
Values copied in range-for.

Prefer returning const references to members rather than copies.

Beltran Fernandez Barbadillo authored 5 months ago and Jiri Masik committed 5 months ago

Change the way retriever tools are fed into AlgoJiveXML.

Define attribute of AlgoJiveXML, which corresponds to an array of retriever tools "m_DataRetrieverTools", to avoid fetching for retriever tools using datatypes. Instead, tools are directly fed into the algorithm (through m_DataRetrieverTools) in JiveXMLConfig.py when configuring the algorithm. Additionally, each Config.py file has been modified to accommodate each retriever tool into its own Cfg function, merging them all into the appropriate package Cfg method (e.g. MuonRetrieversCfg()). These package Cfg methods have also been modified to also output a list of the data retrievers associated to each of the retriever tools contained in their ComponentAccumulator instances. Atlas Extrapolator has been removed from TruthTrackRetrieverCfg() and added into the algorithm configuration in JiveXMLConfig.py. Finally, getDataTypes() method has been removed from JiveXMLConfig.py, as well as the attribute "m_dataTypes" from AlgoJiveXML class definition.

Scott Snyder authored 6 months ago and Johannes Elmsheuser committed 6 months ago

MuonGeoModelTest: Fix cppcheck 2.14 warnings.

Prefer returning const references to members rather than copies.

Liaoshan Shi authored 6 months ago and Duc Ta committed 6 months ago

JiveXML: Update xAODRetrieversConfig.py to enable GN2 in event display

Melissa Yexley authored 6 months ago and Duc Ta committed 6 months ago

Online ed updates

Shaun Roe authored 6 months ago and Vakhtang Tsulaia committed 6 months ago

main-cleanup-Identifier

Liaoshan Shi authored 7 months ago and Duc Ta committed 7 months ago

Update jet retriever for event display

Scott Snyder authored 7 months ago and Adam Edward Barton committed 7 months ago

VP1HEPVis: Fix gcc14 warnings.

Potential use of uninitialized variables.

1. Forward declaration of a `struct` as a `class`
2. Local variable set but not used
3. Unused private data member
4. Reference cannot be bound to dereferenced null pointer
5. Potentially uninitialized variable

Edward Moyse authored 8 months ago and Adam Edward Barton committed 8 months ago

Migrate many hasXXX methods to baseclass, so that we can make TrackHandleBase more generic
Also, add placeholder for Run4EDM