Mark Hodgkinson authored 1 month ago and Tadej Novak committed 1 month ago

Update usage of tracking convertors in PFlow Config

Scott Snyder authored 3 months ago and Jean-Baptiste De Vivie De Regie committed 3 months ago

eflowRec: Fix use of invalid iterators.

annihilateCluster was looping though a vector, erasing each element in turn,
in order to clear the vector.
Not only is this ineffient, it ends up using invalid iterators.
This was causing a crash with gcc15.
Just change to using clear().

Scott Snyder authored 3 months ago and Tadej Novak committed 3 months ago

eflowRec: Fix use of invalid iterators.

annihilateCluster was looping though a vector, erasing each element in turn,
in order to clear the vector.
Not only is this ineffient, it ends up using invalid iterators.
This was causing a crash with gcc15.
Just change to using clear().

Shaun Roe authored 3 months ago and Tadej Novak committed 3 months ago

main-cppcheck-eflowRec

Mark Hodgkinson authored 3 months ago and Tadej Novak committed 3 months ago

Update to pflow topotower config

To allow some cleanups in core packages.

Mark Hodgkinson authored 3 months ago and Johannes Elmsheuser committed 3 months ago

Split pflow general config to allow to call only the meta data config.
Disable thinning in example pflow e/p config.

Mark Hodgkinson authored 4 months ago and Adam Edward Barton committed 4 months ago

Add pflow configuration to run on topotowers

John Derek Chapman authored 4 months ago and Adam Edward Barton committed 4 months ago

Wrap calls to CaloCalibrationHit::particleID()/particleUID() in HepMC::barcode() and HepMC::uniqueID wrapper functions respectively

Mark Hodgkinson authored 4 months ago and Frank Winklmeier committed 4 months ago

Update CPData cell weights

Mark Hodgkinson authored 4 months ago and Vakhtang Tsulaia committed 4 months ago

Add CPData test.
Clean up comments in other tests.

Mark Hodgkinson authored 4 months ago and Tadej Novak committed 4 months ago

Add functionality to store subtracted cells to eflowRecTrack.
Add usage of this for annih cases.

Use `REPORT_MESSAGE` to print warning.

John Derek Chapman authored 6 months ago and Johannes Elmsheuser committed 6 months ago

Reconstruction: Migrating more code away from barcodes

Mark Hodgkinson authored 6 months ago and Walter Lampl committed 6 months ago

Add additional truth flags config.
Bug fix to usage of truth particle links from tracks.

Mark Hodgkinson authored 7 months ago and Walter Lampl committed 7 months ago

Improve documention of usage of pflow pull_015 cuts.

Mark Hodgkinson authored 7 months ago and Tadej Novak committed 7 months ago

Remove legacy useUpdated2015ChargedShowerSubtraction config option. This has been
the default for a long time.
Addresses ATLJETMET-1736

Mark Hodgkinson authored 7 months ago and Adam Edward Barton committed 7 months ago

Add new variable to be written out in CPData mode - the variable is Pull15 which is an
ingredient used to calculate isInDenseEnvironment. Adding this allows diagnostics of
how the isInDenseEnvironment cut selection is performing.

Xiangyang Ju authored 9 months ago and Walter Lampl committed 9 months ago

Apply 1 suggestion(s) to 1 file(s)

Co-authored-by: Lucy Lewitt <lucy.lewitt@cern.ch>

Shaun Roe authored 9 months ago and Adam Edward Barton committed 9 months ago

Apply 1 suggestion(s) to 1 file(s)

Co-authored-by: Adam Edward Barton <adam.edward.barton@cern.ch>

Mark Hodgkinson authored 9 months ago and Vakhtang Tsulaia committed 9 months ago

Add some DEBUG statements.
Some adjustments to treatment of bin lookups to fix lookup bugs.

Maximilian J Swiatlowski authored 9 months ago and Vakhtang Tsulaia committed 9 months ago

Update run4 E/p to v2

Mark Hodgkinson authored 10 months ago and Adam Edward Barton committed 10 months ago

Update particle flow references for Run 4 HL-LHC

Pass strings by const reference, not by value.
Prefer returning const references to members rather than copies.

Fix B015: Result of comparison is not used.

Mark Hodgkinson authored 11 months ago and Frank Winklmeier committed 11 months ago

Remove usage of energy and eta enums in favour of unsigned ints. This will allow
full flexibility to choose an arbitrary set of energy and eta bins.

Fixes ATLASRECTS-7974

Mark Hodgkinson authored 11 months ago and Tadej Novak committed 11 months ago

Update strategy for reference energy bins in particle flow

Maciej Pawel Szymanski authored 11 months ago and Sara Alderweireldt committed 11 months ago

Cleanup output stream name definition and usage

Mark Hodgkinson authored 11 months ago and Vakhtang Tsulaia committed 11 months ago

Add Markdown README

Scott Snyder authored 11 months ago and Vakhtang Tsulaia committed 11 months ago

AthContainers: Move Accessor, etc. classes out of AuxElement.

Accessor and related classes have been members of AuxElement, the original
thinking being that derived classes of AuxElement may want to redefine them.
However, in retrospect, there does not seem to be any circumstance in which
that would actually make sense.  Further, it prevents having any specializations
for these classes.  So move these classes out of AuxElement into the SG
namespace (but with the names brought into AuxElement via using declarations
for backwards compatibility).

Mark Hodgkinson authored 1 year ago and Edward Moyse committed 1 year ago

Make FlowElement container name adjustments more generalised.

Make FlowElement container name adjustments more generalised.