Frank Winklmeier authored 6 months ago and Johannes Elmsheuser committed 6 months ago

TrigEvent: remove usage of deprecated ISvcLoc APIs

MuonR4 - Mdt segmentfit refinement

See merge request !74048

Johannes Junggeburth authored 6 months ago and Johannes Elmsheuser committed 6 months ago

Disable truth segment in data

Trial to incorporate seed update

Sort chambers by number of all seeds

Blub

The thing does not converge

More fit debuggin

Reshuffle file name

Blub

Blub

Fix compiler

Reset

Where's the second seed

Update legend Vol I

Add extra label in file name

Fix crash

Fine tune the pull cut

Renaming of the AxisDefs -> ParamDefs and introduce AxisDefs

Chi2 still off

Blub

Sign hunting

Fix sign convention

Blub

Fix compilation of other packages

Fix y0 sign

Abort also if the fit does not update

Remove logic error

Bail out

Formulation with sin & cos

Plug BEE holes & recalibrate the seed measurements from their own seed

Take any hit which satisfy the pull cut

Put back the phi measurements

debug of pathological events

phi event display

Simplifiy instance counter handling

Clean up messages

Few messages

Apply 1 suggestion(s) to 1 file(s)

Revert changes

Remove warning

extend rad max for strip seeding search in conversion pass with ITk (legacy as well)

See merge request atlas/athena!74429

Carlo Varni authored 6 months ago and Johannes Elmsheuser committed 6 months ago

extend rad max for strip seeding search in conversion pass with ITk (legacy as well)

PileupReweighting: add 2024 run range for MC23e

See merge request atlas/athena!74495

Bertrand Martin Dit Latour authored 6 months ago and Johannes Elmsheuser committed 6 months ago

Hello,

This MR is adding a run range for 2024, from 472553 (first run of period D) to 999999, to support MC23e pileup reweighting. Complements !74403, repetition of !64994 for MC23e.
The run range for MC23d was updated, it starts at the first run of period E and ends at the last run of period I, which should be conservative enough.

With this change, we get rid of the following error when producing PHYSLITE from MC23e
```
02:53:48 2024-09-24 02:53:47,194 CP::TPileupReweighting::Initialize                WARNING Channel 0 has no configuration for period 450000 -- this is symptomatic of you trying to reweight an MC campaign to data not intended for that campaign (e.g. MC16a with 2017 data)
02:53:48 2024-09-24 02:53:47,195 CP::TPileupReweighting::Initialize                WARNING There is 100.000000% unrepresented data and 'IgnoreBadChannels' property is set to true. Will start ignoring channels until this is below the tolerance (5.000000%)
02:53:48 2024-09-24 02:53:47,195 CP::TPileupReweighting::Initialize                WARNING Ignoring channel 0, which has 100.000000% unrepresented data (100.000000% of the total unrep data)
02:53:48 2024-09-24 02:53:47,211 CP::TPileupReweighting::GetPrimaryWeight            ERROR Unrecognised channelNumber 802402 for periodNumber 470000
```

For completeness, MC23e PHYSLITE jobs still fail, but for a different reason
```
Derivation 11:23:03 2024-09-24 11:22:56,011 MuonCalibrationAndSme...calibrationAndSmearingTool  FATAL Could not assign run-number 470000 to a specific year of data-taking
```
FATAL error messages are issued:
https://gitlab.cern.ch/atlas/athena/-/blob/main/PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections/Root/MuonCalibTool.cxx#L614
the job seems to run fine but due to the FATAL messages, job parsing considers that the job failed.

Cheers,
Bertrand

Fix  builds with Sherpa3

See merge request atlas/athena!74491

Andrii Verbytskyi authored 6 months ago and Johannes Elmsheuser committed 6 months ago

Fix  builds with Sherpa3

add MadGraph in FTAG MCMC map

See merge request atlas/athena!74485

BinBin Dong authored 6 months ago and Johannes Elmsheuser committed 6 months ago

add MadGraph in FTAG MCMC map

2024-09-24: merge of 24.0 into main

Closes ATR-27970 and ATEAM-1009

See merge request !74494

Trigger: Acts fixes and a _build test

See merge request atlas/athena!74489

Jiri Masik authored 6 months ago and Johannes Elmsheuser committed 6 months ago

Trigger: Acts fixes and a _build test

Turn on truth for Run4 FTF LRT test

See merge request atlas/athena!74486

Thomas Strebler authored 6 months ago and Johannes Elmsheuser committed 6 months ago

Turn on truth for Run4 FTF LRT test

MCTruthBase+TRT_ConditionsNN: Fix cppcheck 2.14 warnings.

See merge request atlas/athena!74483

Scott Snyder authored 6 months ago and Johannes Elmsheuser committed 6 months ago

MCTruthBase: Fix cppcheck 2.14 warnings.

Prefer returning const references to members rather than copies.

TrkVertexFitterValidationUtils+TrkValEvent: Fix cppcheck 2.14 warnings.

See merge request atlas/athena!74482

Scott Snyder authored 6 months ago and Johannes Elmsheuser committed 6 months ago

TrkVertexFitterValidationUtils: Fix cppcheck 2.14 warnings.

Prefer returning const references to members rather than copies.

MuonConfig - Comment the lines back in

See merge request atlas/athena!74475

Johannes Junggeburth authored 6 months ago and Johannes Elmsheuser committed 6 months ago

MuonConfig - Comment the lines back in

Muon - Decouple MuonCondData from MuonTester Tree

See merge request atlas/athena!74474

Johannes Junggeburth authored 6 months ago and Johannes Elmsheuser committed 6 months ago

Muon - Decouple MuonCondData from MuonTester Tree

Start unit tests for IdDict

See merge request atlas/athena!74472

Shaun Roe authored 6 months ago and Johannes Elmsheuser committed 6 months ago

Start unit tests for IdDict

Add maxEcell variables for tau of DAOD_LLP1

See merge request atlas/athena!74471

Marin Furukawa authored 6 months ago and Johannes Elmsheuser committed 6 months ago

Add maxEcell variables for tau of DAOD_LLP1

AthenaServices: fix Gaudi deprecation warnings

See merge request atlas/athena!74461

introduce some work-arounds to run CP algorithms on Run 4 MC (ATLSWUPGR-193 ATLASG-2785)

See merge request atlas/athena!74457

Nils Erik Krumnack authored 6 months ago and Johannes Elmsheuser committed 6 months ago

introduce some work-arounds to run CP algorithms on Run 4 MC

Essentially I just add a hard-coded random run number to the EventInfo
object, and then shut up or disable any algorithm that don't work on the
file I had.

This is explicitly meant as a temporary "hack" to get the code to run,
and then leave it to the domain experts to implement proper fixes for
each.  The other goal is to hopefully allow Run 4 MC to be included in
the next PHYSLITE campaign.

MuonR4 - Add tests to check overlay & digi chain

See merge request atlas/athena!74455

Johannes Junggeburth authored 6 months ago and Johannes Elmsheuser committed 6 months ago

MuonR4 - Add tests to check overlay & digi chain

Set rad max for the ACTS strip seeding tool

See merge request atlas/athena!74428

Carlo Varni authored 6 months ago and Johannes Elmsheuser committed 6 months ago

Set rad max for the ACTS strip seeding tool

Add Run 4 GN2 training to derivations

See merge request atlas/athena!74406

Leonardo Splendori authored 6 months ago and Johannes Elmsheuser committed 6 months ago

Add Run 4 GN2 training to derivations