And with that, undo the hack that was necessary for successful
Debug builds with earlier versions.

`ATLAS_USE_CPPCHECK` was set in CxxUtils to `ON` but this should not be
done for projects where we do not have cppcheck available. Move the
setting to `Athena` and ensure it is propagated to downstream (i.e.
`WorkDir`) projects.

Closes ATLINFR-5672.

Johannes Elmsheuser authored 2 months ago and Adam Edward Barton committed 2 months ago

AsgTools: Fix compilation with clang19

This reverts commit f786e8d4, reversing
changes made to 27af9504.

Functionality required for running event generation in MP

Attila Krasznahorkay authored 2 months ago and Duc Ta committed 2 months ago

Update Athena to use VecMem-1.13.0.

And with that, undo the hack that was necessary for successful
Debug builds with earlier versions.

Tomohiro Yamazaki authored 2 months ago and Adam Edward Barton committed 2 months ago

Fix alias syntax

Make sure that ROOT batch mode gets set properly.

Thomas Strebler authored 2 months ago and Adam Edward Barton committed 2 months ago

Update Run 4 default geotag

AthExCUDA (Debug Build) Fix, main branch (2024.03.15.)

See merge request atlas/athena!69855

(cherry picked from commit 47dd9b96)

2d8b17d1 Turn off vptr sanitization for the execute function.

Co-authored-by: Walter Lampl <walter.lampl@cern.ch>

Riccardo Maria Bianchi authored 2 months ago and Adam Edward Barton committed 2 months ago

Add new GeoModel.DumpGeo flags and fix DumpGeo CA configuration for transforms and other Athena jobs. Closes ATLASDD-56

Add new GeoModel.DumpGeo flags and fix DumpGeo CA configuration for transforms and other Athena jobs. Closes ATLASDD-56

A few test miscompares.

Jean-Baptiste De Vivie De Regie authored 2 months ago and Duc Ta committed 2 months ago

update condition tags for MC21 Run4 and MC23

Will Buttinger authored 2 months ago and Duc Ta committed 2 months ago

Update SGInputLoader.cxx - promote transient provider-free loads of objects to an error, as usually indicative of missing output declaration

Scott Snyder authored 2 months ago and Tadej Novak committed 2 months ago

CxxUtils: Add set_unaligned functions for writing potentially unaligned data.

Add set_unaligned functions, analogous to the existing get_unaligned functions,
for writing possibly-unaligned data without invoking undefined behavior.

Scott Snyder authored 2 months ago and Tadej Novak committed 2 months ago

AthenaKernel: Additional dictionary entry.

Generate a dictionary for implements<IProxyDict>.
Fixes errors seen in dev3LCG when loading TEvent (which derives
from this).

Scott Snyder authored 2 months ago and Tadej Novak committed 2 months ago

CxxUtils: Avoid spurious division-by-zero FPEs with clang19.

Use CXXUTILS_TRAPPING_FP to tell clang to assume that FP division may trap.

James Catmore authored 2 months ago and Tadej Novak committed 2 months ago

Draft: Adding a new D2AOD format to allow command-line skimming of PHYSLITE

This MR adds a new D2AOD format (D2AOD_SKIM) to the derivatioon framework to allow users to skim PHYSLITE via the command line, rather than the current situation where they must set up their own formats. Usage is:
```
Derivation_tf.py --CA --inputDAOD_PHYSLITEFile DAOD_PHYSLITE.33081115._000042.pool.root.1 --outputD2AODFile test.pool.root --formats SKIM --skimmingString "count(AnalysisMuons.pt > (1 * GeV)) >= 1" --extraDataForDynamicConsumers xAOD::MuonContainer/AnalysisMuons
```
The last argument should be a list of all containers touched by the skiming expression. The skimming string itself is the usual ExpressionEvaluation string, so identical to the strings used in the derivation framework. Per-event content should be identical to PHYSLITE.

This would not be used in official production due to the generic format name. In cases where official production of a PHYSLITE skim were needed, one would need to define a new format as ususal. This could, however, be the basis of a user skimming service, if we decide to have such a thing in the future.

Peter Van Gemmeren authored 2 months ago and Tadej Novak committed 2 months ago

Remove query from EventSelector

Delete obsolete RecAlgs

James Catmore authored 2 months ago and Tadej Novak committed 2 months ago

Adding a WritexAOD example to AthExBasics

We realised during the preparation of the Athena tutorial material that there isn't an example in AthenaExamples showing how an xAOD container should be created and written. This MR provides such an example, as a counterpart to the existing ReadxAOD example.

This needs to be given a *very* close review given that this is supposed to be a template. In particular I'd like to check that everyone approves of the way this is done in the C++, including the use of the new operator... can this be avoided given our coding guidelines?

Will Buttinger authored 2 months ago and Jean-Baptiste De Vivie De Regie committed 2 months ago

Update SGInputLoader.cxx - Repurpose ExtraOutputs property for set of objects created by e.g. eventloop

Scott Snyder authored 2 months ago and Johannes Elmsheuser committed 2 months ago

xAODRootAccess: cmake fix

Bad ROOT component name.

Gid rid of an extra temporary EventInfo copy by making the needed changes
after the EI is copied to the subevent list.
In passing, resolves an issue with mcEventWeights not being copied.

cf ATLASSIM-7404.

Need to explicitly copy mcEventWeights in addSubEvent, if it exists,
as it may be marked as a decoration.

cf ATLASSIM-7404.

Vakhtang Tsulaia authored 2 months ago and Johannes Elmsheuser committed 2 months ago

AthExHive: minor cleanup and refactoring of code in the `src/condEx` directory

Code cleanup and modernization: default destructors, dopped empty finzalization functions,
added event contexts to write condition handle constructors, validity checks for write
condition handles, identation fixes, etc.

Stewart Martin-Haugh authored 2 months ago and Johannes Elmsheuser committed 2 months ago

Apply 1 suggestion(s) to 1 file(s)

Co-authored-by: Frank Winklmeier <frank.winklmeier@cern.ch>

Meisam Farzalipour Tabriz authored 2 months ago and Johannes Elmsheuser committed 2 months ago

Refactor control

Scott Snyder authored 2 months ago and Johannes Elmsheuser committed 2 months ago

CxxUtils: Don't try to use the x87 fsincos instruction any more.

Since a long time, we've had CxxUtils::sincos, which calculates sin and cos
using the x87 fsincos instruction.  At the time, this was significantly
better than the alternatives.  However, with current compilers on x86_64,
it is in fact faster to use the sincos() library function than the x87 instruction.
So remove the inlining bit.
sincos() is still a GNU extension, so don't remove this entirely from CxxUtils ---
this allow us to keep the #ifdefs in one place.

AthExHive_test.sh script switched to the CA-based script

Scott Snyder authored 2 months ago and Johannes Elmsheuser committed 2 months ago

PileUpMT: Update for range-v3 0.12.0.

group_by -> chunk_by (to match c++23).

Andrii Verbytskyi authored 2 months ago and Johannes Elmsheuser committed 2 months ago

Replace boost/mpl with STL type traits

The `athena --help flags` was not working under all circumstances, i.e.
when used with `--help=flags`. Instead of modifying the command line
arguments in `sys.argv`, temporarily disable the help actions in the
argument parser itself.

Alaettin Serhan Mete authored 2 months ago and Jean-Baptiste De Vivie De Regie committed 2 months ago

AthenaConfiguration+AthenaPoolCnvSvc: Allow marking streams as temporary and use ZSTD to compress temporary files instead of ZLIB when possible

Merge branch 'main-introduce-temp-streams' into 'main'

AthenaConfiguration+AthenaPoolCnvSvc+OutputStreamAthenaPool: Add a new flag to mark streams temporary when applicable

See merge request !73463

Minor code cleanup in the `setupLoggingLevels` and `PropSetterProxy`
code, i.e.:
  - print warning in case no property matches
  - improve documentation
  - retrieve `MessageSvc` only when needed