Scott Snyder authored 5 months ago and Tadej Novak committed 5 months ago

G4HiveEx: Adjust conditional for cppcheck.

Adjust so that cppcheck doesn't see the false conditional for gettid.

The explicit `extends2`, `extends3`, etc. classes are no longer required
and can be replaced by the variadic `extends`.

Scott Snyder authored 6 months ago and Johannes Elmsheuser committed 6 months ago

MCTruthBase: Fix cppcheck 2.14 warnings.

Prefer returning const references to members rather than copies.

Prefer returning const references to members rather than copies.

John Derek Chapman authored 8 months ago and Vakhtang Tsulaia committed 8 months ago

Update transient TrackRecords patch themselves using HepMcParticleLink if persistified using TrackRecord_p1

Scott Snyder authored 9 months ago and Edward Moyse committed 9 months ago

G4HiveEx: Use gettid() library call rather than making the syscall directly.

Fixes cppcheck warning.

Andrii Verbytskyi authored 9 months ago and Edward Moyse committed 9 months ago

Move documentation to README.md in the Simulation

John Derek Chapman authored 10 months ago and Vakhtang Tsulaia committed 10 months ago

Clean-up of MCTruth/TrackHelper class

Shaun Roe authored 10 months ago and Frank Winklmeier committed 10 months ago

main-coverity-MCTruth

John Derek Chapman authored 10 months ago and Frank Winklmeier committed 10 months ago

Introduce a common naming scheme for methods and variables related to GenParticles representing particles after all interactions so far

Rename variables and methods related to GenParticles representing the particle being simulated after all interactions so far

John Derek Chapman authored 10 months ago and Frank Winklmeier committed 10 months ago

Introduce a common naming scheme for methods and variables related to primary GenParticles

John Derek Chapman authored 10 months ago and Frank Winklmeier committed 10 months ago

Drop redundant PrimaryParticleInformation::SetParticle() method

John Derek Chapman authored 10 months ago and Frank Winklmeier committed 10 months ago

Clean-up of AtlasG4EventUserInfo

John Derek Chapman authored 10 months ago and Frank Winklmeier committed 10 months ago

Beginning the process of documenting simulation classes

John Derek Chapman authored 10 months ago and Tadej Novak committed 10 months ago

HepMcParticleLink constructor syntax clean-up.

Avoid using 0 in combination with HepMcParticleLink::IS_EVENTNUM in constructor calls as this is not properly supported.
It is more correct to directly use 0 with HepMcParticleLink::IS_POSITION to indicate that the link is to the first
GenEvent in the McEventCollection.

Benjamin Morgan authored 11 months ago and Walter Lampl committed 11 months ago

Add CMake option to enable LTO for AtlasGeant4

Use of LTO in Athena builds is not currently possible if the GCC checker
plugins are in use. These are not yet LTO-aware, leading to build
errors. Disabling these globally or per-LTO-using-package is not
feasible as it could lead to the introduction of bad code.

Whilst the plugins are made LTO-aware, introduce CMake option in Athena
and AthSimulation for enabling LTO builds of the AtlasGeant4 "big"
library. Set to OFF by default so that "normal" builds are unaffected.
Builds wanting LTO can set the option to ON, but must also set
ATLAS_USE_GCC_CHECKERS to OFF in this case.

This reverts commit 9b36ad1f, reversing
changes made to 4d2926b2.

Benjamin Morgan authored 11 months ago and Duc Ta committed 11 months ago

Add CMake option to enable LTO for AtlasGeant4

Use of LTO in Athena builds is not currently possible if the GCC checker
plugins are in use. These are not yet LTO-aware, leading to build
errors. Disabling these globally or per-LTO-using-package is not
feasible as it could lead to the introduction of bad code.

Whilst the plugins are made LTO-aware, introduce CMake option in Athena
and AthSimulation for enabling LTO builds of the AtlasGeant4 "big"
library. Set to OFF by default so that "normal" builds are unaffected.
Builds wanting LTO can set the option to ON, but must also set
ATLAS_USE_GCC_CHECKERS to OFF in this case.

John Derek Chapman authored 11 months ago and Frank Winklmeier committed 11 months ago

Update TruthIncidents and ISFParticle to know about uniqueID

Thomas Strebler authored 11 months ago and Ahmed Tarek committed 11 months ago

Clean up legacy CTB_G4Sim configs

John Derek Chapman authored 1 year ago and Edward Moyse committed 1 year ago

Add status to transient TrackRecord class and add, but not use a new persistent class

John Derek Chapman authored 1 year ago and Edward Moyse committed 1 year ago

Clean-up of TrackRecord header ahead of further updates

John Derek Chapman authored 1 year ago and Frank Winklmeier committed 1 year ago

Migrate Sensitive Detectors to use ID rather than barcode

John Derek Chapman authored 1 year ago and Melissa Yexley committed 1 year ago

Clean-up/Migration of commented out legacy configuration in Simulation packages

John Derek Chapman authored 1 year ago and Walter Lampl committed 1 year ago

Drop obsolete ISFParticle::m_bcid member variable

John Derek Chapman authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

Update HepMcParticleLink interface and clients without changing behaviour

John Derek Chapman authored 1 year ago and Duc Ta committed 1 year ago

Clean-up/Migration of commented out legacy configuration in Simulation packages

John Derek Chapman authored 1 year ago and Melissa Yexley committed 1 year ago

Remove legacy sim config main

John Derek Chapman authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

Remove legacy sim config main

Follow-up to Gaudi v38 update (!66880) for properties that changed from
`list` to `set`. Assign values as `set` instead of relying on the
implicit conversion.

Andrii Verbytskyi authored 1 year ago and Walter Lampl committed 1 year ago

Remove barcodes from the print statements and comments

John Derek Chapman authored 1 year ago and Edward Moyse committed 1 year ago

Compilation fixes for the main--HepMC2 nightly

John Derek Chapman authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

Update TrackBarcodeInfo constructor to take uniqueID as well as barcode + replace some calls to GetParticleBarcode with GetParticleUniqueID

Update classes in MCTruth package to handle Status and UniqueID (part of Barcode migration) (ATLASSIM-6978)

Andrii Verbytskyi authored 1 year ago and Tadej Novak committed 1 year ago

Propagate status() of the ISFParticle in Simulation everywhere

Andrii Verbytskyi authored 1 year ago and Frank Winklmeier committed 1 year ago

Introduce is_same_generator_particle function  and use it in MuonTruthAlgs

Andrii Verbytskyi authored 1 year ago and Frank Winklmeier committed 1 year ago

Update AtlasG4EventUserInfo.h: remove the unused members and functions related to barcodes