Siarhei Harkusha authored 2 months ago and Jean-Baptiste De Vivie De Regie committed 2 months ago

TileTPCnv: Save Tile raw channel collection DSP metadata (ATLASSIM-7403)

For every Tile Calorimeter module the so-called Tile DQ status fragment is written in the ByteStream in every event.
Information from this fragment is then stored in the metadata for the corresponding Tile raw channel collection.
And then the Tile DQ status is produced on the fly using this metadata also.

This information is not saved in the POOL format (it seems to be not needed before).
But if the ByteStream for data overlay is pre-converted in the RDO POOL format to  augment it,
then this information is also needed to produce the correct Tile DQ status.

So, Tile raw channel container converter has been modified to save also the raw channel collection metadata.
This information is saved only in the case when Tile raw channel container comes from the DSP,
and when there are errors in the metadata for the corresponding module.
That means that the metadata are saved only for problematic modules.

To save space some errors (header format and parity errors,
sample format and parity errors, FE and ROD chip mask errors)
are merged into one (memory parity error).

The test for the Tile raw channel converter has been modified to test this functionality
and the corresponing reference file has been update also.

Sanya Solodkov authored 2 months ago and Duc Ta committed 2 months ago

Adding new scripts to read/write Lumi values from CALO COOL DB

Siarhei Harkusha authored 2 months ago and Duc Ta committed 2 months ago

TileSimAlgs: Add CA-based configuration for Tile pulse simulator for Run3

ComponentAccumulator based configuration for Tile pulse simulator
(Tile pulse from digits algorithm) for Run 3 has been added.

Test for Tile pulse simulator configuration has been added.

Scott Snyder authored 2 months ago and Tadej Novak committed 2 months ago

TileConditions: Better error reporting.

If we don't find a drawer, report an error rather than crashing
with a segfault.

Peter Van Gemmeren authored 2 months ago and Tadej Novak committed 2 months ago

Remove query from EventSelector

Stanislav Polacek authored 2 months ago and Duc Ta committed 2 months ago

TileConfiguration+TileMonitoring: Update of Tile Jet monitoring by adding histograms for selected cells

TileConfiguration+TileMonitoring: Update of Tile Jet monitoring by adding histograms for selected cells

John Derek Chapman authored 2 months ago and Johannes Elmsheuser committed 2 months ago

Standardize the location of PackageName_entries.cxx

Twelve packages did not follow the convention of having the PackageName_entries.cxx
file in src/components/. This merge request updates those packages to match all
other packages in the repository.

Shaun Roe authored 2 months ago and Frank Winklmeier committed 2 months ago

main-coverity-TileGeoModel

Uninitialized variable.

(cherry picked from commit c2da6eff45d86c7db1dd9cf3e56faf72694d0127)

Co-authored-by: Johannes Junggeburth <johannes.josef.junggeburth@cern.ch>

Unused privated data member.

Plus some minor code refactoring

Shaun Roe authored 3 months ago and Walter Lampl committed 3 months ago

main-cppcheck-TileRecAlgs

Uninitialized variables.

Shaun Roe authored 3 months ago and Walter Lampl committed 3 months ago

solve cppcheck defect in TileSimAlgs

Scott Snyder authored 3 months ago and Jean-Baptiste De Vivie De Regie committed 3 months ago

TileConditions: Fix array bounds checking.

Fix off-by-one errors in array bounds checks.
Solves crashes seen when building with -D_GLIBCXX_ASSERTIONS.

Shaun Roe authored 4 months ago and Johannes Elmsheuser committed 4 months ago

Coverity: solve leak in TileGeoModel

Most of the unit tests compare serial vs MT execution. There is no need
to keep a difficult to maintain reference file with a long list of
exclusions.

Siarhei Harkusha authored 4 months ago and Jean-Baptiste De Vivie De Regie committed 4 months ago

TileRecEx: Fix Tile D3PD production from physics RAW data

Tile D3PD configuration has been fixed to avoid filling mu event info
information when only Tile Calorimeter is reconstucted from physics RAW data
because this information is not available.

Frank Winklmeier authored 10 months ago and Tadej Novak committed 4 months ago

add a PileUpPretracking ProductionStep to set parameters with a prefix of Bkg_

See merge request atlas/athena!71844

Don't call IRDBAccessSvc::getChildTag() when GeoModel is constructed from an SQLite DB

John Derek Chapman authored 4 months ago and Frank Winklmeier committed 4 months ago

TileSimEx: Update ART local job syntax (ATLASSIM-7336)

Many of the "false positives" have been fixed in our current version of
cppcheck (2.16). Remove the suppression of these defects.

Shaun Roe authored 5 months ago and Tadej Novak committed 5 months ago

main-coverity-TileCalibAlgs

Scripts haven't been updated in 10 years and are still Python 2.