Merge branch 'gcc8.JiveXMLServer-20181011' into 'master'

JiveXMLServer: Fix gcc8 warnings.

See merge request atlas/athena!14932

HLT/Services/JiveXMLServer/src/JiveXMLServer.cxx

@@ -125,7 +125,15 @@ namespace JiveXML {
 
     // Now issue the call with a timeout
     struct timeval timeout; timeout.tv_sec = 1; timeout.tv_usec = 0;
+// xdr_void is defined inconsistently in xdr.h and gets a warning from gcc8.
+#if __GNUC__ >= 8
+# pragma GCC diagnostic push
+# pragma GCC diagnostic ignored "-Wcast-function-type"
+#endif
     clnt_call(client, NULLPROC, (xdrproc_t)xdr_void, NULL, (xdrproc_t)xdr_void, NULL, timeout);
+#if __GNUC__ >= 8
+# pragma GCC diagnostic pop
+#endif
 
     // A pointer to the return value of the thread
     void* ret = NULL;
@@ -238,7 +246,7 @@ namespace JiveXML {
       //Now add the new event
       m_eventStreamMap.insert(EventStreamPair(evtStreamID,event));
     
-    } catch ( std::exception e ) {
+    } catch ( const std::exception& e ) {
       ERS_ERROR("Exception caught while updating event for stream "
                 << evtStreamID.StreamName() << ": " << e.what());
       //Also release the lock in this case