Skip to content
Snippets Groups Projects
  1. Nov 30, 2016
  2. Nov 27, 2016
    • Marco Cattaneo's avatar
      Merge branch 'simplify-lumiseq' into 'master' · 7682471b
      Marco Cattaneo authored
      Simplify LumiSequence: prefer single decoder, single filter
      
      * prefer single decoder instance, used in four sequences, over
         cloning four identical instances, configured identically except
         for their instance name
      * prefer single filter instance, used in four sequences, over
         cloning four identical instances, configured identically except
         for their instance name
      * prefer direct member initialization
      
      See merge request !379
      7682471b
  3. Nov 26, 2016
  4. Nov 25, 2016
  5. Nov 24, 2016
  6. Nov 23, 2016
  7. Nov 22, 2016
    • Marco Cattaneo's avatar
      Merge branch 'STageing-update' into 'master' · 310171f6
      Marco Cattaneo authored
      Added options for the CCE scan taken on 2016-10-25
      
      Added options for the CCE scan taken on 2016-10-25
      
      Modified files:
      Tr/TrackMonitors/doc/release.notes
      Tr/TrackMonitors/options/ITAgeing.py
      Tr/TrackMonitors/options/TTAgeing.py
      Tr/TrackMonitors/options/ganga/STAgeingSubmit.py
      
      See merge request !374
      310171f6
  8. Nov 21, 2016
  9. Nov 19, 2016
    • Marco Cattaneo's avatar
      Merge branch 'modernize-calotools' into 'master' · 6eb13abf
      Marco Cattaneo authored
      Modernize CaloTools
      
      * prefer direct member initialization
      * remove trivial destructors
      * prefer auto
      * prefer assignment to vector over explicit series of push_back
      * prefer std::max over a macro
      * prefer std::unique_ptr over raw pointer + explicit delete
      * prefer static const for static, constant data
      * do not cast if not needed
      * prefer extends over explicit virtual inheritance
      * add const
      
      See merge request !360
      6eb13abf
    • Christopher Rob Jones's avatar
    • Marco Cattaneo's avatar
      Merge branch 'modernize-trackfitevent' into 'master' · cfd8052f
      Marco Cattaneo authored
      Modernize TrackFitEvent
      
      * prefer implicit destructors
      * prefer direct member initialization
      * remove unneccessary static
      * prefer STL algorithms
      * prefer range-based loops
      * add final
      
      See merge request !356
      cfd8052f
    • Marco Cattaneo's avatar
      Merge branch 'patch-1' into 'master' · 02bc337b
      Marco Cattaneo authored
      Fix MCParticle cloning in TrackIPResolutionCheckerNT.cpp
      
      
      
      See merge request !366
      02bc337b
    • Marco Cattaneo's avatar
      Merge branch 'FixAndModerizeVeloTrackMonitor' into 'master' · 8867a684
      Marco Cattaneo authored
      Fixed VeloTrackMonitor to work with online tracks and moderinzed code in VeloRecMonitors
      
      Fixed VeloTrackMonitor so that the 2nd metal layer effects monitoring histograms are produced in the BrunelOnline environment (uses lite not full clusters in fits)
      
      Also modernized and fixed coverity warnings in 
      VeloTrackMonitor, VeloExpertClusterMonitor, VeloIPResolutionMonitor, VeloIPResolutionMonitorNT, VeloOccupancyMonitor and VeloSamplingMonitor:
      * Removed empty destructor
      * Simplified constructors
      * Used auto
      * Removed unused variables
      * Better array initialisation
      * Used C++11 lambdas rather than boost lambda and bind.
      * Remove m_binary and replace with LHCb::Math::sqrt_12 
      * Initialise all pointers in class to nullptr explicitly
      * Removed $Id: lines from headers
      * Removed WIN32 #pragmas
      * Removed commented out subroutines
      
      Also fixed PVResolution
      * Several issues with column types in tuples
      * Increased track size array from 100 to 500 (was running out of space every tenth event in 2015 data used in tests)
      * Many optimisations (copying tracks twice just to count number of left/right was not ideal)
      
      In VeloOccupancyMontior fixed coverity error about Time of check/Time of use when doing mkdir (now one operation)
      
      See merge request !358
      8867a684
  10. Nov 18, 2016
  11. Nov 17, 2016
  12. Nov 16, 2016
    • Marco Cattaneo's avatar
      Merge branch 'UseReentrantTransportSvcCalls' into 'master' · f59c17df
      Marco Cattaneo authored
      Adapt to the new re-entrant TransportSvc calls
      
      Adapts to lhcb/LHCb!422
      
      In the Rich, the tool in question is never going to be used in a threaded application (I have something different in RichFuture) so I just create the cache once and save it, in a non thread safe way, as effectively what was happening before inside the `TransportSvc`.
      
      `DetailedMaterialLocator` needs to be made thread safe though. For the moment I have done this in a non optimal way, by just creating the cache before each call.
      
      ```
            auto cache = m_transportSvc->createCache(); // Need a better solution
            rc = m_transportSvc->intersections_r( start, vect, mintick, maxtick, intersepts, 
                                                  cache, m_minRadThickness, m_geometry);
      ```
      
      But this needs to be handled better. I think though that can only be correctly done by pushing the creating and handling of the cache further up the call stack. 
      
      See merge request !352
      f59c17df
    • Gerhard Raven's avatar
      Modernize TrackMonitors · fc83610a
      Gerhard Raven authored
      * add final
      * remove unneeded gsl_math include
      * prefer implicit destructors
      * prefer STL algorithms
      * prefer lambda for predicates
      * prefer auto
      fc83610a
    • David Hutchcroft's avatar
    • Gerhard Raven's avatar
      Modernize PatPV · 166ad547
      Gerhard Raven authored
      * prefer struct for classes with only public data/methods
      * remove SVN/CVS keywords
      * prefer direct member initialization
      * remove trivial destructors
      * prefer range-based loops
      * add final
      166ad547
    • tnikodem's avatar
      handled StatusCode as NOT a boolean · 13ea6ab2
      tnikodem authored
      13ea6ab2
    • tnikodem's avatar
      024a276c
    • Gerhard Raven's avatar
      Modernize CaloTools · e459d50e
      Gerhard Raven authored
      * prefer direct member initialization
      * remove trivial destructors
      * prefer auto
      * prefer assignment to vector over explicit series of push_back
      * prefer std::max over a macro
      * prefer std::unique_ptr over raw pointer + explicit delete
      * prefer static const for static, constant data
      * do not cast if not needed
      * prefer extends over explicit virtual inheritance
      * add const
      e459d50e
  13. Nov 15, 2016
  14. Nov 14, 2016
  15. Nov 11, 2016
Loading