Skip to content

[NILE-816] Change LoraRouting to appName instead of devName

Dean Dalianis requested to merge NILE_692_off_qa into qa

Apart from the change in **LoraRouting ** (ApplicationName -> DeviceName) the following changes were made (mainly us suggestions; we can extend them or remove them):

  • Added CHANGELOG.MD. It makes changes and updates more visible, thus makes our life when working on any project easier.
  • Started writing unit tests and moving away from main tests. This is a small read for test naming conventions: https://dzone.com/articles/7-popular-unit-test-naming. We can discuss and use it if you think it fits.
  • Tried to extract methods and homogenize stream classes: LoraRouting & LoraFlattener. We could follow the same logic in all stream classes and finally extract common methods so we have less code duplication.

(As a further suggestion; we could also start using Lombok to have a bit cleaner code. This is a change I haven't made, since I already am a little bit out of scope for the issue.)

(There has been a confusion with issue number: correct issue is [NILE-816])

Edited by Dean Dalianis

Merge request reports