- Jun 30, 2021
-
-
Nils Erik Krumnack authored
Adding "analysis strategy" and PCBT to fixed cut efficiency conversion for GNN See merge request atlas/athena!44677
-
-
- Jun 28, 2021
-
-
Nils Erik Krumnack authored
FFJetmearingTool memory leak bugfix See merge request atlas/athena!44732
-
-
Andrew Mehta authored
-
Andrew Mehta authored
-
- Jun 25, 2021
-
-
Nils Erik Krumnack authored
AnalysisTop: Disable FFJetSmearingTool when running nominal-only See merge request atlas/athena!44691
-
- Jun 24, 2021
-
-
Oliver Majersky authored
-
Nils Erik Krumnack authored
sweep updates to central AnalysisBase packages from master to 21.2 See merge request atlas/athena!44538
-
Nils Krumnack authored
-
- Jun 23, 2021
-
-
Nils Krumnack authored
-
- Jun 22, 2021
-
-
Nils Erik Krumnack authored
Implementing PseudoData smearing in one event loop in AnalysisTop See merge request atlas/athena!44523
-
-
- Jun 18, 2021
-
-
Nils Krumnack authored
-
Nils Krumnack authored
The ultimate goal here is to have the python configurable no longer inherit from the C++ object, and instead create the C++ object only at the moment when it is needed, instead of having it as a base class and performing all updates simultaneously to the python object and the C++ object (to keep them in sync). However, for now it mostly adds an alternate way of adding algorithms to jobs, to actually make the more fundamental change to the configurables would require all users to update to the new formalism of adding algorithms to jobs. This also allows additional configurable objects to be used, e.g. I now treat algorithm sequences and algorithms the same. This could potentially also be used to change the target or mechanism of configuration at some point, e.g. to push this into an intermediate JSON file, but that's not an immediate goal.
-
Nils Erik Krumnack authored
Since I'm back-porting to 21.2 I didn't modify the AnaToolHandle implementation, but I did update AsgComponentConfig accordingly. Original commit message: The basic reasoning here is that AnaToolHandle is essentially the out-dated and discouraged mechanism for creating tools, and has been replaced with AsgToolConfig for quite a while (or alternatively indirectly via AnaAlgorithmConfig). I did have to disable some Athena tests for setting sub-tools in Athena. There are already some of those disabled, and the basic logic is that since this is the legacy way of doing things, unless this breaks existing code (as verified by CI tests) I no longer want to support all the possible edge cases in this rather brittle and complex piece of code.
-
Nils Krumnack authored
For now this just replaces the algorithm with a service, and communicates the systematics list via the service interface instead of via the event store. The plan is to add more functionality in future merge requests that will move a lot of the systematics handling functionality from the configuration layer into the service.
-
Nils Krumnack authored
As part of implementing my first dual-use service I decided that the existing macros are not quite as elegant as I hoped, and also don't match gaudi mechanisms as closely as I would have liked. I also updated the dual-use service configuration, so that it works nicely in a dual-use setting.
-
Nils Krumnack authored
That was introduced by two recent merge requests crossing.
-
scott snyder authored
Don't let cppcheck see the #error directives.
-
Pierre Antoine Delsart authored
-
Nils Krumnack authored
The goal here is to introduce a single python configurable in AnalysisBase, instead of the current scheme in which there is a separate configurable for AnaAlgorithm, AsgTool, etc. and essentially duplicating a lot of code. For now this duplicates even more code. Once this is all tested and validated, the old code will eitehr be completely removed or made to inherit from the new classes.
-
Nils Krumnack authored
Mostly so that it acts as a test of whether the EventLoop python configuration would work properly on the grid.
-
Nils Krumnack authored
I thought I had added all missing dictionaries, but there is one missing here.
-
Nils Krumnack authored
That was more or less a copy-paste error of a template function that was never instantiated.
-
Nils Krumnack authored
Unfortunately I don't have a really good way to test if it works, but the underlying C++ is tested, and this is hopefully a close enough duplication of what's happening for non-array tools that this is good enough. Originally I tried to do something more involved, but that became sort of tedious given the logic of the python class. Maybe at some point I will come back and restructure the python class somewhat. Hopefully this is still workable as is.
-
Nils Krumnack authored
The changes introduced in !42411 required additional dictionaries to serialize any of the component configuration objects, which were not defined in that merge request. This is (apparently) not caught in any unit tests, but it leads to any sub-tools to be stripped off algorithms during batch and grid submission. This MR should fix that by defining one dictionary and changing the type of one member variable to avoid the need for the second. At some point a new test should be defined to catch these problems in CI, or at least in the nightly tests, but for now having a quick fix seemed more important.
-
Nils Krumnack authored
This is meant as a drop-in replacement for `AnaAlgorithm` in standalone applications that don't need most of its advanced features and just need an easy way to configure and create a public tool.
-
Nils Erik Krumnack authored
Originally the goal was just to allow handling `ToolHandleArray` properties, but it turned out to be a lot easier if subtools are represented by `AsgToolConfig` in turn.
-
Christos Anastopoulos authored
AsgServices add ATLAS_CHECK_THREAD_SAFETY. 1st it passes it . 2nd we inherit now from it for code to be used in Athena production
-
Nils Erik Krumnack authored
AnalysisTop: small fix for using soft muons on TRUTH1 derivations See merge request atlas/athena!44486
-
- Jun 17, 2021
-
-
Marco Vanadia authored
-
Andrew Mehta authored
-
Andrew Mehta authored
-
- Jun 16, 2021
-
-
Oana Vickey Boeriu authored
21.2 Adding DL1d and DIPS into FTAG2 derivations See merge request atlas/athena!44302
-
-
Nils Erik Krumnack authored
Fix FPE due to log(X) where X <= 0 in jet mass calibration See merge request atlas/athena!44419
-
- Jun 15, 2021
-
-
Oana Vickey Boeriu authored
Fixing truthTag for DL1r See merge request atlas/athena!44342
-
Steven Schramm authored
This FPE was first seen in r22, but is present in both r21 and r22. This commit is the r21 fix, which can then be swept into r22. Note that the choice was made to keep the same behaviour as the current tool, which looked for NaNs instead of preventing their creation in the first place. That is, negative logarithms result in a calibration factor of 1 (no calibration) or a calibration weight of 0 (for combined mass calibrations).
-
Cristiano Alpigiani authored
-