VP1: fix remainng cppcheck defects

See merge request atlas/athena!76616

Herwig7_i: remove dead code relying on CMTPATH

See merge request atlas/athena!76597

Use ForcedSurfaceReached when propagating to the perigee surface

See merge request atlas/athena!76606

Tomasz Bold authored 4 months ago and Tadej Novak committed 4 months ago

Use ForcedSurfaceReached when propagating to the perigee surface

EvtInclusiveDecay: remove dead code relying on CMT

See merge request atlas/athena!76583

GeneratorPhysVal: fix cppcheck defects

See merge request atlas/athena!76586

ControlTest+AthenaMonitoringKernel: fix cppcheck defects

See merge request atlas/athena!76581

SimTimeEstimate: move property and variable initialization to header file

See merge request atlas/athena!76588

TruthConverters+TruthIO: fix cppcheck defects

See merge request atlas/athena!76589

Generators: fix cppcheck defects

See merge request !76590

AthViews: use common Gaudi test fixture

See merge request atlas/athena!76593

ReadHandle: suppress cppcheck false positive missingReturn

See merge request atlas/athena!76580

Rivet_i: remove dead code relying on CMTPATH

See merge request atlas/athena!76596

GlobalSimulation: Fix uninitialized variable warning.

See merge request atlas/athena!76600

Scott Snyder authored 4 months ago and Tadej Novak committed 4 months ago

GlobalSimulation: Fix uninitialized variable warning.

Fix warning about possible use of uninitialized variable
(seen in hepmc2 build).

ZWindowRoISeedTool: Fix compilation warning.

See merge request atlas/athena!76605

Scott Snyder authored 4 months ago and Tadej Novak committed 4 months ago

ZWindowRoISeedTool: Fix compilation warning.

Unused typedef.

CxxUtils: remove cppcheck suppression in features.h

See merge request atlas/athena!76595

InDetAlignmentMonitoringRun3: cmake fix

See merge request atlas/athena!76607

Scott Snyder authored 4 months ago and Tadej Novak committed 4 months ago

InDetAlignmentMonitoringRun3: cmake fix

Fix external dependency declarations.

AthenaKernel: Reduce header dependencies for ClassName.h.

See merge request atlas/athena!76604

Scott Snyder authored 4 months ago and Tadej Novak committed 4 months ago

AthenaKernel: Reduce header dependencies for ClassName.h.

Add Athena::typeinfoName, an out-of-line wrapper for System:typeinfoName.
This allows to reduce header dependencies on the Gaudi System.h header.

TestTools: Fix equality test for TestAlloc.

See merge request atlas/athena!76603

Scott Snyder authored 4 months ago and Tadej Novak committed 4 months ago

TestTools: Fix equality test for TestAlloc.

TestAlloc has no state, so consider all instances equal.
Fixes failure with swap when _GLIBCXX_ASSERTIONS is enabled.

ALFA_Raw2Digit: Fix cppcheck warnings.

See merge request atlas/athena!76610

Scott Snyder authored 4 months ago and Tadej Novak committed 4 months ago

ALFA_Raw2Digit: Fix cppcheck warnings.

Redundant string conversions.
Prefer to initialize class members in an initialization list.

MuonIdHelperSvc: fixed clang warnings

See merge request atlas/athena!76613

EventDisplaysOnline: use thread-safe getgrnam_r

See merge request atlas/athena!76615

update geometry to the latest ATLAS-P2-RUN4-04-00-00

See merge request atlas/athena!76571

Jiri Masik authored 4 months ago and Tadej Novak committed 4 months ago

update geometry to the latest ATLAS-P2-RUN4-04-00-00

Fix pass-by-ref and potential nullptr deref.

Unused local variables

`CMTPATH` is no longer set so we can remove code relying on it.

The `CMTPATH` environment variable is not set anymore. So we can remove
all (dead) code relying on it.

The preprocessor error suppression does not seem to be necessary anymore.

Uninitialized variable and copy in range-based loop.