Follow-up from "GitlabPagesSite operator"
The following discussions from !8 (merged) should be addressed:
-
@alossent started a discussion: Note that the CSV gets copied to every namespace (we expect 1000s of them) so it's worth using as small an icon file as possible so as not to increase memory usage on masters too much. Current icon at 32KB is massive, I would look for something in the 1-2KB range
-
@alossent started a discussion: I think we need a comment to explain that we don't set
specDescriptors
and instead give users permission to read the GPS CRD so OKD console will auto-generate the form. -
@alossent started a discussion: This operator only supports
AllNamespaces
(deployment ignores any OLM-supplied namespace) -
@alossent started a discussion: Suggest to use a go-template comment instead to keep the generated vhost file smaller (since we have constraints on total configmap/secret size)
-
@alossent started a discussion: I see there are a lot of
context.TODO()
. We should consistently pass thectx
received byReconcile
- it's super annoying to have to pass thectx
argument to almost every method, but that's how we're supposed to do. -
@alossent started a discussion: The
spec
should be set insideCreateOrUpdate
, otherwise it's only set at route creation and the operator won't ever "fix" any spec that has derived from the expected spec.