Clarify updates to CR and refactor updates to the CR
The following discussion from !4 (merged) should be addressed:
-
@alossent started a discussion: Is it correct to
Requeue
here? The status has been modified, so the PaasSite resource has been modified and a newUPDATE
event will be queued already.The reconcile results should be more consistent and better documented/commented. Why do we have
Requeue: true
in places and not others? And when has the PaasSite resource status been updated or not? Current design hides the resource status updates inside methods likeupdateOwner
, but the correct reconcile results depends on whether the resource was modified or not. This needs to be improved and if possible more consistent (e.g. always update status after updating something?)