diff --git a/GaudiHive/src/IOBoundAlgSchedulerSvc.h b/GaudiHive/src/IOBoundAlgSchedulerSvc.h index 064e1957c13e86251f7285bd342f62951ab61df6..272b2e2348b1ca71cd0d8277eaf82948f52bb4cb 100644 --- a/GaudiHive/src/IOBoundAlgSchedulerSvc.h +++ b/GaudiHive/src/IOBoundAlgSchedulerSvc.h @@ -46,7 +46,7 @@ private: StatusCode deactivate(); /// Flag to track if the scheduler is active or not - bool m_isActive; + bool m_isActive = false; /// The thread in which the activate function runs std::thread m_thread; diff --git a/GaudiRelease/doc/release.notes.v30r2.md b/GaudiRelease/doc/release.notes.v30r2.md index 4bef11f7b9379286dbfc1f1d56c50c197fd8e903..8420d3ae9435fc3d5549b7da6c7ac238c627e971 100644 --- a/GaudiRelease/doc/release.notes.v30r2.md +++ b/GaudiRelease/doc/release.notes.v30r2.md @@ -1,6 +1,6 @@ --- version: v30r2 -date: 2018-03-19 +date: 2018-03-20 supported_builds: [CMake] --- Package Coordinators: Marco Clemencic, Charles Leggett, Benedikt Hegner @@ -48,6 +48,7 @@ incompatible change. * AvalancheSchedulerSvc: Fix undefined output ordering ([mr !635][]) * Fix warnings seen when compiling with gcc8 ([mr !638][]) * Prevent property deprecation warnings when unpickling options ([mr !641][]) + * Fixed a couple of bugs found by Coverity ([mr !644][]) * [Build System][] * Fixed typo in CMake option name ([mr !578][]) * Fix distcc support and add icecream ([mr !585][]) @@ -176,6 +177,7 @@ The full list of changes can also be found on [Gitlab][]. [mr !638]: https://gitlab.cern.ch/gaudi/Gaudi/merge_requests/638 [mr !639]: https://gitlab.cern.ch/gaudi/Gaudi/merge_requests/639 [mr !641]: https://gitlab.cern.ch/gaudi/Gaudi/merge_requests/641 +[mr !644]: https://gitlab.cern.ch/gaudi/Gaudi/merge_requests/644 [Bug Fix]: https://gitlab.cern.ch/gaudi/Gaudi/merge_requests?label_name%5B%5D=bug+fix&scope=all&state=merged&milestone_title=v30r2 [Build System]: https://gitlab.cern.ch/gaudi/Gaudi/merge_requests?label_name%5B%5D=build+system&scope=all&state=merged&milestone_title=v30r2 diff --git a/GaudiSvc/src/THistSvc/THistSvc.icc b/GaudiSvc/src/THistSvc/THistSvc.icc index 6c34454bbc45b8fadc0f7bc7efc8ebbb670f0731..1638fbd261bec65a9750c5c79ae11b06342d6c81 100644 --- a/GaudiSvc/src/THistSvc/THistSvc.icc +++ b/GaudiSvc/src/THistSvc/THistSvc.icc @@ -293,7 +293,7 @@ LockedHandle<T> THistSvc::regShared_i( const std::string& id, std::unique_ptr<T> T* phist = dynamic_cast<T*>( hid->obj ); if ( phist == 0 ) { error() << "regSharedHist: unable to dcast retrieved shared hist \"" << id << "\" of type " - << hid->obj->IsA()->GetName() << " to requested type " << phist->IsA()->GetName() << endmsg; + << hid->obj->IsA()->GetName() << " to requested type " << System::typeinfoName( typeid( T ) ) << endmsg; } else { lh.set( phist, hid->mutex ); delete hist.release(); diff --git a/ReleaseNotes/v30r2.md b/ReleaseNotes/v30r2.md index 4bef11f7b9379286dbfc1f1d56c50c197fd8e903..8420d3ae9435fc3d5549b7da6c7ac238c627e971 100644 --- a/ReleaseNotes/v30r2.md +++ b/ReleaseNotes/v30r2.md @@ -1,6 +1,6 @@ --- version: v30r2 -date: 2018-03-19 +date: 2018-03-20 supported_builds: [CMake] --- Package Coordinators: Marco Clemencic, Charles Leggett, Benedikt Hegner @@ -48,6 +48,7 @@ incompatible change. * AvalancheSchedulerSvc: Fix undefined output ordering ([mr !635][]) * Fix warnings seen when compiling with gcc8 ([mr !638][]) * Prevent property deprecation warnings when unpickling options ([mr !641][]) + * Fixed a couple of bugs found by Coverity ([mr !644][]) * [Build System][] * Fixed typo in CMake option name ([mr !578][]) * Fix distcc support and add icecream ([mr !585][]) @@ -176,6 +177,7 @@ The full list of changes can also be found on [Gitlab][]. [mr !638]: https://gitlab.cern.ch/gaudi/Gaudi/merge_requests/638 [mr !639]: https://gitlab.cern.ch/gaudi/Gaudi/merge_requests/639 [mr !641]: https://gitlab.cern.ch/gaudi/Gaudi/merge_requests/641 +[mr !644]: https://gitlab.cern.ch/gaudi/Gaudi/merge_requests/644 [Bug Fix]: https://gitlab.cern.ch/gaudi/Gaudi/merge_requests?label_name%5B%5D=bug+fix&scope=all&state=merged&milestone_title=v30r2 [Build System]: https://gitlab.cern.ch/gaudi/Gaudi/merge_requests?label_name%5B%5D=build+system&scope=all&state=merged&milestone_title=v30r2