if taken from Git it's also distributed in the installation directory

- make the correct job to fail in case of problems
- keep artifacts also in case of failure

Marco Clemencic authored 7 years ago and Gerhard Raven committed 7 years ago

there is a difference in the output of clang-format-4.0 and
clang-format-3.9.

We will switch to a more recent version when it's available to
everybody.

This reverts commit a7d61ae0.

to keep test artifacts for debugging

According to https://docs.gitlab.com/ce/ci/variables/ it's more URL
friendly than CI_COMMIT_REF_NAME.

See https://about.gitlab.com/2017/03/22/gitlab-9-0-released/#gitlab-ci-ce-ee

See https://cern.service-now.com/service-portal/article.do?n=KB0003905

see https://gitlab.com/gitlab-org/gitlab-ci-multi-runner/issues/336