Prefer returning const references to members rather than copies.

Shaun Roe authored 8 months ago and Tadej Novak committed 8 months ago

main-coverity-AthenaRootComps

Prefer returning const references to members rather than copies.

Prefer returning const references to members rather than copies.

Prefer returning const references to members rather than copies.

Prefer returning const references to members rather than copies.

Paul Thompson authored 8 months ago and Duc Ta committed 8 months ago

Allow to copy blobs as strings for root files

Prefer returning const references to members rather than copies.

TPCnv libraries declare Gaudi plugin factories for the TP converters.
Normally, the TPCnv libraries should not be linked against libraries
other than the EventPool libraries.  However, it is possible for one
TPCnv library to link against another TPCnv library.
In that case, genconf may emit warnings that one library's factory
is visible from another.  Clean up by moving TPCnv factories into their
own libraries (linked against the corresponding TPCnv library).

Marcin Nowak authored 8 months ago and Tadej Novak committed 8 months ago

Reduce the number of DataHeaderForms (hopefully to one)

Workaround gcc bug 109703 (fixed in gcc 13.2) where constructing a
string from a pair of iterators can trigger ubsan.

Scott Snyder authored 8 months ago and Adam Edward Barton committed 8 months ago

AthenaRootComps: Increase test timeouts.

Increase timeouts for a few tests that have been timing out in the dbg build.

Alaettin Serhan Mete authored 8 months ago and Adam Edward Barton committed 8 months ago

AthenaConfiguration+AthenaPoolCnvSvc+OutputStreamAthenaPool: Add a new flag to mark streams temporary when applicable

AthenaConfiguration+AthenaPoolCnvSvc+OutputStreamAthenaPool: Add a new flag to mark streams temporary when applicable

Scott Snyder authored 9 months ago and Edward Moyse committed 9 months ago

AthenaPoolUtilities: Ignore PGO messages in ref file comparisons.

In some builds, we get annoying PGO messages at the end of a job,
stemming from the acts libraries.  Add this to the patterns to ignore
when comparing with ref files.  Prevents some spurious comparison
failures.

Scott Snyder authored 9 months ago and Adam Edward Barton committed 9 months ago

AthenaPoolUtilities: Fix cppcheck 2.14 warnings.

Prefer returning const references to members rather than copies.

cppcheck claims uninitialized variables in the constructor despite them
being initialized there. Giving them defaults seems to fix this.

Scott Snyder authored 9 months ago and Vakhtang Tsulaia committed 9 months ago

AthContainers: Add getVector() methods to IConstAuxStore.

Add IConstAuxStore::getVector() return the IAuxTypeVector interface
for the contained auxiliary variables.

I resisted adding this for quite a while, in order to avoid restricting
how the AuxStores could be implemented.  However, this turns out to be
useful, and in fact every AuxStore implementation that's actually used
maintains IAuxTypeVector interfaces to the auxiliary variables (and even
for the one that currently doesn't, AuxStoreConstMem, we could implement
enough to get things working, if needed).

Maciej Pawel Szymanski authored 9 months ago and Tadej Novak committed 9 months ago

Enable writing and reading of std::string in RootKeyContainer

Shaun Roe authored 9 months ago and Tadej Novak committed 9 months ago

main-coverity-RootStorageSvc

Marcin Nowak authored 9 months ago and Tadej Novak committed 9 months ago

Better mutex locking in PoolSvc for MT

A rare crash was observed in access to the mutex vector. These changes
should provide better protection against concurrent access to this
vector.

Maciej Pawel Szymanski authored 9 months ago and Tadej Novak committed 9 months ago

Allow opening RootKeyContainers starting with slash

Scott Snyder authored 9 months ago and Tadej Novak committed 9 months ago

CoolConvUtilities: Fix python regular expression.

A string constant used for an RE that contains backslash RE escapes
should usually be written as a raw string.
Fixes a warning seen running AtlCoolConsole.py.

Alaettin Serhan Mete authored 9 months ago and Tadej Novak committed 9 months ago

AthenaPoolCnvSvc+RootStorageSvc: Workaround for the ROOT forward compatibility issue

Mikhail Mineev authored 9 months ago and Tadej Novak committed 9 months ago

modification to use https prefix in CREST URL

Scott Snyder authored 9 months ago and Tadej Novak committed 9 months ago

IOVDbSvc: Fix cppcheck 2.14 warnings.

Redundant string conversion.
Prefer returning const references to members rather than copies.

Scott Snyder authored 9 months ago and Tadej Novak committed 9 months ago

AthContainersRoot+RootAuxDynIO+xAODRootAccess+AthenaPoolCnvSvc+TrigNavigation+TrigOutputHandling: Handle I/O of linked variables.

AthContainersRoot: Handle I/O of linked variables.

Handle I/O of linked variables.

Scott Snyder authored 10 months ago and Walter Lampl committed 10 months ago

AthenaPoolUtilities: Improve diagnostics.
    
If a test fails, be sure to print a reference to the log file at the end.

Scott Snyder authored 10 months ago and Walter Lampl committed 10 months ago

IOVDbSvc: cmake fix

Duplicated source file.

Scott Snyder authored 10 months ago and Walter Lampl committed 10 months ago

CoolConvUtilities: Fix cppcheck 2.14 warnings.

Prefer returning const references to members rather than copies.

Scott Snyder authored 10 months ago and Walter Lampl committed 10 months ago

RootCollection: Fix cppcheck warning.

Calling a virtual function from a dtor does not use virtual dispatch.

Scott Snyder authored 10 months ago and Edward Moyse committed 10 months ago

CoolConvUtilities: Fix ATLAS_COOL_FORCESQLITE option.

Fix ATLAS_COOL_FORCESQLITE option of AtlCoolLib.

Plus minor code cleanups

If some table is not found in the input SQLite file, then it should be printed
as INFO

Scott Snyder authored 10 months ago and Edward Moyse committed 10 months ago

RootCollection: Fix placement of using declarations.

Don't put using declarations in the global namespace before an #include.

Scott Snyder authored 10 months ago and Edward Moyse committed 10 months ago

AthenaKernel: Rename IMetaDataSvc to IAthMetaDataSvc.

To avoid conflicts with a different interface of the same name in Gaudi.