Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
athena
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Locked files
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Fabrizio Salvatore
athena
Commits
aef4b5c5
Commit
aef4b5c5
authored
6 years ago
by
Scott Snyder
Committed by
scott snyder
6 years ago
Browse files
Options
Downloads
Patches
Plain Diff
TrkParticleCreator: Fix clang warnings.
clang warnings: Missing override keywords. Former-commit-id:
4a7bdb2c
parent
719cff1c
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
Tracking/TrkTools/TrkParticleCreator/TrkParticleCreator/TrackParticleCreatorTool.h
+10
-5
10 additions, 5 deletions
...icleCreator/TrkParticleCreator/TrackParticleCreatorTool.h
with
10 additions
and
5 deletions
Tracking/TrkTools/TrkParticleCreator/TrkParticleCreator/TrackParticleCreatorTool.h
+
10
−
5
View file @
aef4b5c5
/*
Copyright (C) 2002-201
7
CERN for the benefit of the ATLAS collaboration
Copyright (C) 2002-201
8
CERN for the benefit of the ATLAS collaboration
*/
/***************************************************************************
...
...
@@ -73,8 +73,8 @@ namespace Trk {
virtual
~
TrackParticleCreatorTool
();
virtual
StatusCode
initialize
();
virtual
StatusCode
finalize
();
virtual
StatusCode
initialize
()
override
;
virtual
StatusCode
finalize
()
override
;
/** Method to construct a TrackParticle from a passed Track. Currently, it will ONLY fill the MeasuredPerigee
i.e. the TrackParticle will not be complete
...
...
@@ -85,6 +85,7 @@ namespace Trk {
@warning In my opinion, the interface is not optimal - we're not taking ownership of the Trk::Track or Vx::Candidate,
so they should be passed by reference.
*/
virtual
Rec
::
TrackParticle
*
createParticle
(
const
Trk
::
Track
*
track
,
const
Trk
::
VxCandidate
*
vxCandidate
,
Trk
::
TrackParticleOrigin
prtOrigin
)
override
;
...
...
@@ -93,7 +94,8 @@ namespace Trk {
@param track particle
@param TrackParticleContainer needed to have an AuxStore, if provided particle will be added to store which takes ownership
*/
xAOD
::
TrackParticle
*
createParticle
(
const
Rec
::
TrackParticle
&
trackParticle
,
xAOD
::
TrackParticleContainer
*
container
)
const
;
virtual
xAOD
::
TrackParticle
*
createParticle
(
const
Rec
::
TrackParticle
&
trackParticle
,
xAOD
::
TrackParticleContainer
*
container
)
const
override
;
/** Method to construct a xAOD::TrackParticle from a passed Track. Currently, it will ONLY fill the MeasuredPerigee
i.e. the TrackParticle will not be complete
...
...
@@ -104,6 +106,7 @@ namespace Trk {
@warning In my opinion, the interface is not optimal - we're not taking ownership of the Trk::Track or Vx::Candidate,
so they should be passed by reference.
*/
virtual
xAOD
::
TrackParticle
*
createParticle
(
const
Trk
::
Track
&
track
,
xAOD
::
TrackParticleContainer
*
container
,
const
xAOD
::
Vertex
*
vxCandidate
,
...
...
@@ -116,17 +119,19 @@ namespace Trk {
@param xAOD::Vertex Pointer to a valid vxCandidate (i.e. do not pass a zero!). Ownership is not taken (i.e. it will not be deleted)
@param prtOrigin
*/
virtual
xAOD
::
TrackParticle
*
createParticle
(
const
ElementLink
<
TrackCollection
>&
trackLink
,
xAOD
::
TrackParticleContainer
*
container
,
const
xAOD
::
Vertex
*
vxCandidate
,
xAOD
::
ParticleHypothesis
prtOrigin
)
const
override
;
/** create a xAOD::TrackParticle out of constituents */
virtual
xAOD
::
TrackParticle
*
createParticle
(
const
Perigee
*
perigee
,
const
FitQuality
*
fq
,
const
TrackInfo
*
trackInfo
,
const
TrackSummary
*
summary
,
const
std
::
vector
<
const
Trk
::
TrackParameters
*>&
parameters
,
const
std
::
vector
<
xAOD
::
ParameterPosition
>&
positions
,
xAOD
::
ParticleHypothesis
prtOrigin
,
xAOD
::
TrackParticleContainer
*
container
)
const
;
xAOD
::
TrackParticleContainer
*
container
)
const
override
;
/** Method to set FitQuality of a xAOD::TrackParticle */
void
setFitQuality
(
xAOD
::
TrackParticle
&
tp
,
const
FitQuality
&
fq
)
const
;
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment