VP1Utils: Fix gcc8 warnings.

gcc8 warnings: Catching polymorphic exception by value.



Former-commit-id: 6913a0fe

graphics/VP1/VP1Utils/VP1Utils/VP1SGAccessHelper.icc

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2018 CERN for the benefit of the ATLAS collaboration
 */
 
 
@@ -73,7 +73,7 @@ inline bool VP1SGAccessHelper::retrieve(const DataHandle<T>& begin, const DataHa
   try {
     sc = storeGate()->retrieve(begin,end);
     exception = false;
-  } catch (std::runtime_error e) {
+  } catch (const std::runtime_error& e) {
     exception = true;
   }
   if (exception) {

graphics/VP1/VP1Utils/VP1Utils/VP1ToolAccessHelper.icc

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2018 CERN for the benefit of the ATLAS collaboration
 */
 
 
@@ -40,7 +40,7 @@ inline toolT * VP1ToolAccessHelper::getToolPointer( const QString& tooltypeandna
     try {
       retrieveok = !toolhandle.retrieve().isFailure();
       exception = false;
-    } catch (std::runtime_error e) {
+    } catch (const std::runtime_error& e) {
       exception = true;
     }
     if (exception) {