Skip to content
Snippets Groups Projects

Better support for legacy cases

Merged Gerardo Ganis requested to merge fix-for-rpms into master
2 unresolved threads

To run the testing, add a comment with:

Bot test PACKAGE|all in TOOLCHAIN|all [(only|also) for LABEL-COMPILER-BUILDTYPE] please!

To ensure patches required for existing LCG branches are not lost, please add the respective labels: alsoTargeting:LCG_102-patches, alsoTargeting:master, etc.

Edited by Andre Sailer

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
248 copy_to_eos(str(Path(tmparea) / f"LCG_{version}" / f'{t}*.rpm'), eosmgmurl + target[t.startswith('LCG')], dryrun)
192 249
193 250
194 251 if __name__ == "__main__":
195 main()
252 parser = argparse.ArgumentParser()
253 parser.add_argument("version", help="LCG release version, e.g. 88 ot 97python3")
254 parser.add_argument("repo", help="Path to target RPM repository, ignored in legacy mode")
255 parser.add_argument("platform", help="Platform, ignored in legacy mode")
256 parser.add_argument("-n", "--dryrun", default=False, action="store_true")
257 parser.add_argument("--legacy", default=False, action="store_true", help="Legacy mode: for LCG_96 and older")
258 parser.add_argument("--legacy101", default=False, action="store_true", help="Internediate mode: for LCG_97-LCG_101")
259 args = parser.parse_args()
260
261 if args.legacy101:
262 // LCG_101 and older
  • 247 for t in list_to_copy:
    248 copy_to_eos(str(Path(tmparea) / f"LCG_{version}" / f'{t}*.rpm'), eosmgmurl + target[t.startswith('LCG')], dryrun)
    192 249
    193 250
    194 251 if __name__ == "__main__":
    195 main()
    252 parser = argparse.ArgumentParser()
    253 parser.add_argument("version", help="LCG release version, e.g. 88 ot 97python3")
    254 parser.add_argument("repo", help="Path to target RPM repository, ignored in legacy mode")
    255 parser.add_argument("platform", help="Platform, ignored in legacy mode")
    256 parser.add_argument("-n", "--dryrun", default=False, action="store_true")
    257 parser.add_argument("--legacy", default=False, action="store_true", help="Legacy mode: for LCG_96 and older")
    258 parser.add_argument("--legacy101", default=False, action="store_true", help="Internediate mode: for LCG_97-LCG_101")
    259 args = parser.parse_args()
    260
    261 if args.legacy101:
  • Andre Sailer
  • Andre Sailer
  • I think I don't even know what the purpose of complete_rpms_action is in itself. A short description at the top of the file would be good

  • Gerardo Ganis added 1 commit

    added 1 commit

    Compare with previous version

  • Gerardo Ganis added 1 commit

    added 1 commit

    • 8d27bfe7 - Make sure that the repository root is always defined

    Compare with previous version

  • Andre Sailer approved this merge request

    approved this merge request

  • Andre Sailer marked this merge request as ready

    marked this merge request as ready

  • merged

  • Andre Sailer mentioned in commit 9c6fb2a0

    mentioned in commit 9c6fb2a0

  • A deleted user added sweep:done label

    added sweep:done label

  • Ghost User picked the changes into the branch cherry-pick-9c6fb2a05-LCG_102-patches with commit 296e912a

    picked the changes into the branch cherry-pick-9c6fb2a05-LCG_102-patches with commit 296e912a

  • Andre Sailer mentioned in commit 296e912a

    mentioned in commit 296e912a

  • Contributor

    Sweep summary

    Sweep ran in https://gitlab.cern.ch/sft/lcgcmake/-/jobs/22791864
    Successful:

    • LCG_102-patches
  • Ghost User mentioned in merge request !1331 (merged)

    mentioned in merge request !1331 (merged)

  • Andre Sailer mentioned in commit bd727b77

    mentioned in commit bd727b77

  • Please register or sign in to reply
    Loading