Skip to content

onnxruntime: do not use custom flags and run cmake install

Juan Miguel Carceller requested to merge jcarcell/lcgcmake:onnxruntime into master

Reasons not to use the custom flags:

  • Release is passed in the build step and then the flags are overwritten
  • The flags were added when GCC 13 came out but now it builds fine without those for GCC 13
  • RelWithDebInfo is supported but in the docs they say that some optimizations may be missed in this mode (probably because they build with -O3 with Release and -O2 with RelWithDebInfo

On the modification of the installation commands, the issue here is that the cmake files are not being installed and onnxruntime can not be trivially found from CMake. Instead of copying files manually and having to maintain the commands we can just use what is specified from onnxruntime, as it is done in Spack.

  • In my tests building on Alma9 the library and the cmake files are installed to lib64 instead of lib as it is done now. The python files stay in lib.
  • The include folder changes: currently it looks like include/core/<several-folders> and with this change it looks like include/onnxruntime/... where only a subset of the folders are installed.
Edited by Juan Miguel Carceller

Merge request reports

Loading