G(oogle)Test Not built with optimised/debug flags
It should fix SPI-1709
Merge request reports
Activity
added test-needed label
1089 1089 LCGPackage_Add( 1090 1090 gtest 1091 1091 URL ${GenURL}/googletest-release-${gtest_native_version}.tar.gz 1092 CONFIGURE_COMMAND ${CMAKE_COMMAND} -DCMAKE_INSTALL_PREFIX=<INSTALL_DIR> -Dgtest_build_samples=ON <SOURCE_DIR> 1093 BUILD_COMMAND ${MAKE} 1094 INSTALL_COMMAND ${MAKE} install 1095 # INSTALL_COMMAND ${CMAKE_COMMAND} -E make_directory <INSTALL_DIR>/lib 1096 # COMMAND ${CMAKE_COMMAND} -E make_directory <INSTALL_DIR>/include 1097 # COMMAND ${CMAKE_COMMAND} -E copy <SOURCE_DIR>/googlemock/gtest/libgtest.a <INSTALL_DIR>/lib/. 1098 # COMMAND ${CMAKE_COMMAND} -E copy <SOURCE_DIR>/googlemock/gtest/libgtest_main.a <INSTALL_DIR>/lib/. 1099 # COMMAND ${CMAKE_COMMAND} -E copy <SOURCE_DIR>/googletest/include/gtest/gtest.h <INSTALL_DIR>/include/. 1100 # COMMAND ${CMAKE_COMMAND} -E copy_directory <SOURCE_DIR>/gmock/include <INSTALL_DIR> 1101 1102 # BUILD_IN_SOURCE 1 1092 CMAKE_ARGS -DCMAKE_INSTALL_PREFIX=<INSTALL_DIR> 1093 -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} As I pointed out in SPI-1709, I believe you'll need to hardcode
Release
here for now. Otherwise clients will be unable to use the debug LCG builds because of:https://gitlab.kitware.com/cmake/cmake/-/merge_requests/4950
Note that even CMake 3.18.3, which was released "just now" still doesn't have that fix.
😦 changed this line in version 2 of the diff
🤖 🗩 Build running: https://lcgapp-services.cern.ch/spi-jenkins/job/lcg_personal_experimental_archdocker_nonblocking/271Edited by LCG GitLab bot🤖 🗩 Build running: https://lcgapp-services.cern.ch/spi-jenkins/job/lcg_personal_experimental_archdocker_nonblocking/272Edited by LCG GitLab bot🤖 🗩 Build running: https://lcgapp-services.cern.ch/spi-jenkins/job/lcg_personal_experimental_archdocker_nonblocking/273Edited by LCG GitLab botadded test-dev3python3-passed label
🤖 🗩Build results for job lcg_personal_experimental_archdocker_nonblocking, release dev3python3
Build #273 - SUCCESS
Platform Result Release,clang1000binutils,lcg_docker_cc7 ✅ Release,clang800binutils,lcg_docker_cc7 ✅ Release,gcc10binutils,lcg_docker_cc7 ✅ Release,gcc8binutils,lcg_docker_cc7 ✅ Release,gcc8binutils,lcg_docker_slc6 ✅ Release,gcc9binutils,lcg_docker_cc7 ✅ added test-dev4-passed label
🤖 🗩Build results for job lcg_personal_experimental_archdocker_nonblocking, release dev4
Build #272 - SUCCESS
Platform Result Debug,clang1000binutils,lcg_docker_cc7 ✅ Debug,gcc10binutils,lcg_docker_cc7 ✅ Debug,gcc8binutils,lcg_docker_cc7 ✅ Debug,gcc8binutils,lcg_docker_slc6 ✅ Debug,gcc9binutils,lcg_docker_cc7 ✅ Release,clang1000binutils,lcg_docker_cc7 ✅ Release,gcc10binutils,lcg_docker_cc7 ✅ Release,gcc8binutils,lcg_docker_cc7 ✅ Release,gcc8binutils,lcg_docker_slc6 ✅ Release,gcc9binutils,lcg_docker_cc7 ✅ added test-dev3-passed label
🤖 🗩Build results for job lcg_personal_experimental_archdocker_nonblocking, release dev3
Build #271 - SUCCESS
Platform Result Debug,clang1000binutils,lcg_docker_cc7 ✅ Debug,gcc10binutils,lcg_docker_cc7 ✅ Debug,gcc8binutils,lcg_docker_cc7 ✅ Debug,gcc8binutils,lcg_docker_slc6 ✅ Debug,gcc9binutils,lcg_docker_cc7 ✅ Release,clang1000binutils,lcg_docker_cc7 ✅ Release,gcc10binutils,lcg_docker_cc7 ✅ Release,gcc8binutils,lcg_docker_cc7 ✅ Release,gcc8binutils,lcg_docker_slc6 ✅ Release,gcc9binutils,lcg_docker_cc7 ✅ mentioned in commit f8e82b37