Walter Lampl authored 4 years ago and Edward Moyse committed 4 years ago

rename TRT_BSErrContainer into TRT_BSErrContainer_p1 (to serve as persistent version), create new transient TRT_BSErrContainer mimicking the interface of the TRT_ByteStream_ConditionsSvc

The thread-safety checker was not properly checking calls to virtual functions.
When that is fixed, we get a warning about the call to
IPRDtoTrackMapExchange::setPRDtoTrackMap.

This is indeed not thread safe, and is supposed to be used only for
backwards compatibility with run 2.

To resolve this, split out the non-thread-safe part into a separate function.
We suppress the thread-safety checker warning in the call to it,
but we also explicitly check and fail the job if we're running
such a run 2 configuration with more than one thread.

Susumu Oda authored 4 years ago and Frank Winklmeier committed 4 years ago

Add using std::abs as protection against missing #include <cmath> when  using namespace std is used.

- Moved mutable members into EventData struct or replaced them by local variables
  which are passed through.
- Made member functions constant.
- Removed remaining magnetic field init callback. Field mode now adjusted per event.
- Removed most stream operators to dump tools. The dump methods which provide the
  actual functionality are still available.

Goetz Gaycken authored 5 years ago and Walter Lampl committed 5 years ago

- Use a PRD-to-track map rather than the PRD_AssociationTool which conains a PRD-to-track map
  internally. This is needed to resolve ATLASRECTS-5005.
- Made all methods const.
- The score processor does not create track copies anymore, thus PRD-to-track maps stay valid for
  scored tracks.
- The ambiguity processors now use a helper class which manages the new and original tracks i.e.
  tracks with mixed ownership, and creates track copies only for the final track collection if
  necessary.
- Moved debug ntuple code of simple ambiguity processor to a new derived class, to improve the
  readability.

Fix path for TrkEventUtils.

The association map is stored in storegate for cases in which the PRD association
is shared across multiple algorithms. The PRD_AssociationTool is still used for the
cases in which the PRD association is shared between multiple tools but which are
all related to a single algorithm instance. Thus, the PRD_AssociationTool still has
to be public for tha latter cases. The current configuration does not ensure
that tool instances are confined to single algorithms. Thus, in case of more than
one thread, different algorithms may still operate concurrently on the same internal
association map, which can be mitigated by configuration changes (to be done).

Susumu Oda authored 5 years ago and Vakhtang Tsulaia committed 5 years ago

Drop PixelDetectorManager from PixelClusterization and remove UsePixelDetectorManager = True from configuration

The `used_packages.html` files are a relic from CMT times, hopelessly
outdated and not useful anymore.

Enable static thread checker for all packages in InDetTrigRecAlgs.
Exclude a few files with legacy trigger code from checks.

Susumu Oda authored 5 years ago and Walter Lampl committed 5 years ago

Rename SiSpacePointsSeedTool_xk/EventData to SiSPSeededTrackFinderData/SiSpacePointsSeedMakerEventData

Susumu Oda authored 5 years ago and Vakhtang Tsulaia committed 5 years ago

Remove << operators and dump(SiTrackMakerEventData_xk& data, std::ostream& out) because they are not so useful due to the separation of event dependent data, SiTrackMakerEventData_xk.