Mark Hodgkinson authored 4 years ago and Edward Moyse committed 4 years ago

Also remove hard coding of conditons tag, which is no longer needed.

Hello,

This MR is changing the seed jet pt cut from 10 GeV to 0 GeV in the tau reconstruction.
It does not change the reconstruction output, because this cut is set upstream to 15 GeV in the jet reconstruction: https://gitlab.cern.ch/atlas/athena/-/blob/master/Reconstruction/Jet/JetRec/share/JetRec_jobOptions.py#L33.
However, for the R22 reprocessing, we will have to drop this 15 GeV cut from the AntiKt4LCTopo jet reconstruction (by setting jetFlags.useCalibJetThreshold to False), and instead apply a tau pt cut at the end of the tau reconstruction, in the tau thinning algorithm.

Cheers,
Bertrand

Try to fix ATLASRECTS-6027 , Also try to format MuonCreatorTool, run clang-tidy for nullptr, qualified auto etc

Scott Snyder authored 4 years ago and Vakhtang Tsulaia committed 4 years ago

Avoid spurious copies in range-for loops.

Scott Snyder authored 4 years ago and Vakhtang Tsulaia committed 4 years ago

Avoid spurious copy in range-for.

Nils Erik Krumnack authored 4 years ago and Atlas Nightlybuild committed 4 years ago

Adjust JetUncertainties mass-scale accessors to be created where they are used

See merge request atlas/athena!41421

(cherry picked from commit 7c7f931fe0d0bd5b7ca19a9afbedc438ca4dd0ca)

099367ee Initialising accessors where actually used

Hello,

This MR is just a tiny code improvement.
We are selecting the track category with highest probability. Instead of looping over 5 categories, we now loop over 4 categories...
The reconstruction output is unchanged.

Cheers,
Bertrand

Increase slightly the timeout for the TrackParticleTPCnv_16.6.3 test.
It has been timing out frequently in dbg builds.

Adding the inside-out reco to the muon triggers in the new JO test (ATR-20388):

- Add the inside-out reco algorithms to the muon trigger configuration, and run in a sequence only if we don't find any muons in the outside-in reco sequence
- Add the configuration for the algorithms that check for outside-in muons and merges the muon trigger containers
- Update the muon reco config to remove a couple cases of unneeded 'addPublicTools' and to use the correct track summary tool for a given use case (CombinedMuonTrackSummaryTool when looking at combined muons, and the MuonTrackSummaryTool otherwise)

Remove trigger python files from trace excludes that no longer exist.

Johannes Junggeburth authored 4 years ago and Adam Edward Barton committed 4 years ago

Use the ME track particle for hit counting if the MS is not there. This is following the primaryTrackParticle logic dropping the ID track

    
Removing some const_casts from SimpleAmbiguityProcessor.

    
Removing some const_casts from SimpleAmbiguityProcessor.

This splits up the current ISystematicsTool into two interfaces, one
part from which tools can inherit if they want to implement
systematics in a thread-friendly manner, and one which contains the
current interface and inherits from the former.  See interface
documentation for more details.

Edward Moyse authored 4 years ago and Adam Edward Barton committed 4 years ago

This was discussed in the reconstruction meeting 02.03.2021.

Hello,

This MR is simply renaming the combined Tau Energy Scale 4-momentum from e.g. pt_combined to ptCombined, to follow the TES naming convention.
That may cause some troubles transiently, if new code is used to read old xAODs/DAODs, but it's better to do this sooner than later.

Cheers,
Bertrand

Christos Anastopoulos authored 4 years ago and Adam Edward Barton committed 4 years ago

Surfaces , finalize the move of all parameter factories i.e create...parameters to either unique_ptr or value return types , from plain ptr. Follow up to ATLASRECTS-5967

Explicitly tell cling to read headers defining several xAOD containers,
to avoid hitting cling bugs when METMakerConfig loads TauAnalysisTools.

See ATLASRECTS-6059.

Hello,

In R22, we are not writing out tau charged PFOs in xAODs, because tau charged PFOs are supposed to be identical to tau tracks.
In this MR, we "safely replace" charged PFOs with tau tracks in one tool, so that the tool can be rerun on xAODs.

However... charged PFOs are actually only created for taus that have 1-5 tracks:
https://gitlab.cern.ch/atlas/athena/-/blob/master/Reconstruction/tauRecTools/src/TauPi0ClusterScaler.cxx#L29-44

This must have been overlooked in the MVA tau energy scale code, where "charged_totalE" is supposed to be the total energy carried by tau tracks, even when taus have more than 5 tracks...
The "charged_totalE" variable was null for taus with more than 5 tracks (these taus not used in analyses fortunately), and the behaviour is now fixed.
This MR does not change the reconstruction output for taus with at most 5 tracks.

Cheers,
Bertrand

In getTrackVertexAssocTool, we need to set the TrackContName property
of the association tool.

Mark Hodgkinson authored 4 years ago and Edward Moyse committed 4 years ago

Bug fix for e/p mode such that we don't attach multiple clusters corresponding to the same cluster to charged PFO

To remove the dependency on the deprecated TriggerMenu package, import
the slice flags from TriggerJobOpts.

Don't add a track decoration tool if it's already done by a separate algorithm.

Actually, decoration should probably always be scheduled as a separate
algorithm, which the jet configuration can request.  That may work better
though with the new job configuration, so won't try to implement that
at this point.

See ATLASRECTS-6055 / ATLASRECTS-6057.