Nicholas Styles authored 3 years ago and Edward Moyse committed 3 years ago

fix adding of noise to use SiCellId directly - works for ITkStrip as well as SCT, and avoids an extra conversion step

Mismatched header guard.

Christos Anastopoulos authored 3 years ago and Edward Moyse committed 3 years ago

Define a separate scoped enumeration for the possible SurfaceTypes. And use it consistently. The motivation is that there is a cross dependency creeping in from ParameterBase to Surface and Surface impl to ParametersBase due to that enum. Also a single scoped enum allows to unify the usage syntax

Linking against `SGTests` is only needed if the `StoreGate/SGtests.h` is
used.

Relates to the duplicate CLID errors discussed in ATEAM-731.

Nicholas Styles authored 3 years ago and Frank Winklmeier committed 3 years ago

retrieve nStrips once and pass through interfaces as reference, to avoid mutliple retrivals and inconsisten ranges

Remove vestigial references to CaloNoiseTool.

The decoration availability check is performed per container, thus testing
the availability of a certain decoration for each truth particle is incorrect.
Now, decorations are only applied if the decorations are not yet present in
the TruthParticle container.

Christos Anastopoulos authored 3 years ago and Frank Winklmeier committed 3 years ago

Remove unsafe localToGlobal returning naked ptr. In favour of value i.e what was added as localToGlobalPos. Migrate clients. In cases this fixes potential memory leaks, thankfully in test code

Anthony Morley authored 3 years ago and Frank Winklmeier committed 3 years ago

Update beamspot reconstruction and correct error in InDetRecExample which allows it to run when there is no calo information

Christos Anastopoulos authored 3 years ago and Frank Winklmeier committed 3 years ago

Avoid/remove covariance matrix allocations from clients of TrackParameters. use std::optional intrernally to express that is "nullable" but allow for value semantics

Frank Winklmeier authored 3 years ago and Johannes Elmsheuser committed 3 years ago

Remove usage of obsolete `PACKAGE_VERSION` macro. Also cleanup
essentially empty methods.

Having replaced all the use of the old RegSelSvc but the new component specific RegSelTools and their related RegSelCondAlgs, we can now remove the remaining RegSelSvc code, and the componenet specific code for each RegionSelectorTable class, ie

 InnerDetector/InDetDetDescr/InDetRegionSelector
 MuonSpectrometer/MuonDetDescr/MuonRegionSelector

The LAR and TileCal code was already modified by Denis, so no changes needed for

 LArCalorimeter/LArRegionSelector
 TileCalorimeter/TileRawUtils

Relates to ATR-19657, and replaces !41361

Christian Sander authored 3 years ago and Johannes Elmsheuser committed 3 years ago

- Now LB dependent HitMaps are created for NoisyStrip and Dead/Quiet Chip task

Some members which are only used when writing special seed ntuples are not
always initialised. This caused occasional FPEs when the assignment operator
was called. Now these members are always initialised to zero.

Mark Sutton authored 3 years ago and Johannes Elmsheuser committed 3 years ago

This si strange, if we patched it before because of differenece, and not we run again
asking if we want to reverse the patch what does that mean ? That the same reference is used
by two different jobs, each of which gives different output ?

Missing override keywords.