Frank Winklmeier authored 3 years ago and Johannes Elmsheuser committed 3 years ago

Remove usage of obsolete `PACKAGE_VERSION` macro. Also cleanup
essentially empty methods.

Christian Sander authored 3 years ago and Johannes Elmsheuser committed 3 years ago

- Now LB dependent HitMaps are created for NoisyStrip and Dead/Quiet Chip task

Christian Sander authored 4 years ago and Edward Moyse committed 4 years ago

Added thresholds for occupancy for quiet chip/strip (default: 0.5 * mean occupancy)

Suppress false positive.

Use standard atlas_install_runtime.

Prefer preincrement to postincrement for user iterators.
Remove useless pointer dereferences.

- updated copyright info

covFromSi is obviously meant to be a 2x2 matrix, not 1x1!.
Fixes out-of-bounds warning from gcc10.

The deadmap format will be changed in rel.22.
The previous DB folder was /PIXEL/PixMapOverlay, and new folder /PIXEL/PixelModuleFeMask .
This new folder is not included in old global tag.
Thus, in the job option, the DB-tag is specified, but this should be removed when the q-test update new global tag.
Unfortunately, q221 uses old global tag, OFLCOND-MC16-SDR-25, which associates PixMapOverlay-SIM-MC16-000-02.
But the RUN-2 best-knowledge tag is based on PixMapOverlay-SIM-MC16-000-03, and new deadmap conditions also based on this tag (-03).
Therefore, the q221 test will not pass T0 policy. The reference file is updated.
On the other hand, the data q431 is no problem.

    
Don't use references in a range-for if the object must be copied.

Christian Sander authored 4 years ago and Frank Winklmeier committed 4 years ago

- removed relativ paths
- updated sorting of lists

Frank Winklmeier authored 4 years ago and Edward Moyse committed 4 years ago

Gaudi v35 drops the backwards compatiblity imports of `GaudiSvcConf`.
Import the services from their actual location.

cmake cleanup, do not install component headers.

The single RegSelSvc is to be replaced by a separate RegSelTool for each subsystem.

This merge request is to implement that migration for the ID code.

This code contains about 60 % of all the changes that are needed for the migration,
and most of the changes for the pixel, SCT and TRT.

```
For information the packages needing changes are
Innerdetector/InDetEventCnv/PixelRawDataByteStreamCnv
InnerDetector/InDetEventCnv/TRT_RawDataByteStreamCnv
InnerDetector/InDetExample/InDetRecExample
InnerDetector/InDetRecAlgs/InDetPrepRawDataFormation
InnerDetector/InDetRecTools/TRT_SeededSpacePointFinderTool

Reconstruction/TRT_Rec
Reconstruction/iPat/iPatRecExample

Innerdetector/InDetExample/InDetTrigRecExample

InnerDetector/InDetTrigRecAlgs/InDetTrigPrepRawDataFormat
InnerDetector/InDetTrigRecAlgs/InDetTrigRawDataProvider
InnerDetector/InDetTrigRecAlgs/SiTrigSPSeededTrackFinder
InnerDetector/InDetTrigRecAlgs/SiTrigSpacePointFormation
InnerDetector/InDetTrigRecAlgs/TRT_TrigSeededTrackFinder
InnerDetector/InDetTrigRecAlgs/TRT_TrigTrackSegmentsFinder

Trigger/TrigTools/TrigOnlineSpacePointTool
Trigger/TriggerCommon/TriggerJobOpts

Trigger/TrigAlgorithms/TrigGenericAlgs
Trigger/TrigAlgorithms/TrigT2MinBias
Trigger/TrigHypothesis/TrigLongLivedParticlesHypo
```

plus the configuratin for every package that uses any of the above packages which will need to
instantiate the RegSelTools for the tool and algorithms configurables.

Clean up to remove most thread-safety annotations.
Algorithm PixelChargeToTConversion is marked as not thread-safe
because it modifies data in SG.

Thread-safety annotations should match between declarations and definitions.
Clean up some static variables.
TRTCalibrationMgr is not thread-safe due to its use of TRTCalibrator.

Library dependency fixes.

Library dependency fixes.

Library dependency fixes.

Library dependency fixes.

Remove needless ATLAS_NOT_THREAD_SAFE attribute from
MultiHisto::Write.  The const_cast here is adding const, not removing it,
so it's ok.

Susumu Oda authored 4 years ago and Walter Lampl committed 4 years ago

Add ATLAS_NOT_THREAD_SAFE to PixelChargeInterpolationPlot and PixelClusterOnTrackErrorPlot classes because static variables are used.

Susumu Oda authored 4 years ago and Frank Winklmeier committed 4 years ago

Add ATLAS_CHECK_THREAD_SAFETY to TRT_CalibAlgs package. Remove const keyword from TRTCalibrationMgr::streamOutCalibObjects to avoid const_cast. Add ATLAS_NOT_THREAD_SAFE to TRT_StrawStatus class because it reads and writes a global variable (last_lumiBlock0). Add ATLAS_NOT_THREAD_SAFE to TRTOccupancyInclude::execute method because static variables are used.

Move the reasons of trhead unsafety to the lines of ATLAS_NOT_THREAD_SAFE or ATLAS_NO_CHECK_FILE_THREAD_SAFETY for easier understanding using LXR and git grep. Remove ATLAS_NOT_THREAD_SAFE from TRT_BSErrContainerCnv_p1::transToPers and TRT_BSErrContainerCnv_p2::transToPers.

Susumu Oda authored 4 years ago and Frank Winklmeier committed 4 years ago

Add ATLAS_CHECK_THREAD_SAFETY to InDetBeamSpotFinder package. Change static counter to member variable using std::atomic. Remove thread-unsafe DataHandle. Add ATLAS_NO_CHECK_FILE_THREAD_SAFETY to InDetBeamSpotVertex.h/cxx because exteranl methods are used for TMinuit.