Remove vestigial references to CaloNoiseTool.

Frank Winklmeier authored 3 years ago and Johannes Elmsheuser committed 3 years ago

Remove usage of obsolete `PACKAGE_VERSION` macro. Also cleanup
essentially empty methods.

Fix undefined conversion between TH1F* and TH1D*.

Avoid spurious copy in range-for loop.

Use common configurations for SCT conditions summary, hole search and track
summary tools.

Fix flake8 warnings that slipped through while flake8 checking was
broken in master.

ATLASRECTS-5967,ATLASRECTS-5932 : Move IUpdator to returning unique_ptr. Update header of the tools implementing the IUpdator interface. Update implementation of the tools. First pass on updating the clients

    
Don't use references in a range-for if the object must be copised.

Use configured hole search in TRT, SCT, SCT hit efficiency and Pixel monitoring
disable hole search tool if unused, and abort if hole search is enabled, but
the hole search tool is not correctly configured.

    
Don't use references in a range-for if the object must be copised.

    
Don't use references in a range-for if the object must be copised.

- Unused private data members (left commented-out as they are referenced
  from already commented-out code).
- endmsg is not for iostream.

Made the package depend on FFTW, to fulfil a runtime dependency
for RooFFTConvPdf, and also cleaned up the configuration a bit at
the same time.