Denis Oliveira Damazio authored 4 years ago and Adam Edward Barton committed 4 years ago

Preparing C++ and python infrastructure for SC AutoCorrNoise CondAlg to be included in Full Simulation

Remove obsolete/unused class TestLArConditionsTools.
It relies on obsolete tools.

Migrate LArDSPThresholdFillInline from CaloNoiseTool to CaloNoise.

Walter Lampl authored 4 years ago and Adam Edward Barton committed 4 years ago

LArRawChannelBuilderAlgConfig, iteration case: Avoid usage of legacy flags through LArConditionsCommon.LArCool

Migrate LArRawChannelMonTool from CaloNoiseTool to CaloNoise.

Migrate remaining users of CaloNoiseTool in this package to CaloNoise.

Fix more instances of python 2 print statements.

Also fix a duplicate porperty declaration.

Remove the code that dumps the HLT menu into an XML file. Not clear why
this was useful but certainly it is not supported for Run-3.

Use preincrement rather than postincrement for iterators.

With the removal of `L1TopoValDataCnv` this flag serves no purpose
anymore.

Fix cppcheck warning.

Use geoGetVolumes in LArVolumeBuilder::getChild to avoid N^2 behavior.

More patterns to ignore in reference file comparision.

Fixes test failure in master.

LArRawChannelBuilderAlgConfig, iteration case: Avoid usage of legacy flags through LArConditionsCommon.LArCool

New path LArCalorimeter/LArTest/LArSCellTest

Fix cppcheck warnings.
Also some general cleanup.

Fix cppcheck warnings.

Fix cppcheck warnings.

Fix cppcheck warnings.

Fix cppcheck warnings.

Denis Oliveira Damazio authored 4 years ago and Edward Moyse committed 4 years ago

eliminating unecessary lock and using directly the pointers. Why didn't I listen to Pavol the first time?

Out-of-bounds vector reference.

Don't put using directives in the global namespace in headers.

Stewart Martin-Haugh authored 4 years ago and Frank Winklmeier committed 4 years ago

Remove TriggerGetter (capable of setting up both Run 2 TrigSteer_HLT and Run 3-ready TriggerConfig/TrigDecisionTool) and migrated clients to T0TriggerGetter which can only do TriggerConfig/TrigDecisionTool. Part of ATR-22725

Remove undefined/unneeded use of ROOT_* macros.

Also add a couple missing test reference files.

Don't use is/is not with a string literal.