Bertrand Martin Dit Latour authored 4 years ago and Adam Edward Barton committed 4 years ago

Hello,

As discussed in ATLASRECTS-6106 and ATLASRECTS-6104, we make an unnecessary and inappropriate use of Decorator on non-const objects, and we should have used Accessor instead.
Now fixed in TauTrackFinder.
Note for later: this could be a bit more streamlined by using the TauTrack::setDetail functionality of the EDM, extending the TrackDetail enum in TauDefs.h.

This MR does not change the reconstruction output.

Cheers,
Bertrand

Christos Anastopoulos authored 4 years ago and Adam Edward Barton committed 4 years ago

ATLASRECTS-6104 . Replace un-needed Decorators with Accessors. As input is const. Also qualify auto, use empty, use nullptr

Simplified the logic in the CMakeLists.txt file, and split the
tool dictionaries into a new library (tauRecToolsDict) instead
of having them in tauRecToolsLib.

Fixed a small issue in tauRecTools/TrackSort.h, which would've
made it unusable in AthAnalysis. (Currently that header is not
included in an AthAnalysis build.)

The main motivation was to make sure that the public headers of the
package would be properly installed in "Athena mode", in order for
the dictionary to work correctly.

But the cleanup grew into something more. I replaced the CINT
dictionary of the package into a Reflex one, introduced the
PanTauAlgsLib library that would be built in all circumstances,
cleaned up the dependencies of the package, and made sure that
the dictionary would refer to types with their correct names.

This is primarily meant to fix the issue described in ATEAM-721.

Loss of precision in int->float conversion.

Christos Anastopoulos authored 4 years ago and Edward Moyse committed 4 years ago

ATLASRECTS-6103 :CaloIsolation, remove unused (option seems to be always false), non-thread safe code

Kerstin Tackmann authored 4 years ago and Edward Moyse committed 4 years ago

Add histograms for more detailed checks of conversion reconstruction: vs pileup, fake conversions, track precision hit fraction and TRT PID.

Make sure all members of LayerConfig are initialized.

Protect against out-of-bounds vector access.

Mark Hodgkinson authored 4 years ago and Edward Moyse committed 4 years ago

Also remove hard coding of conditons tag, which is no longer needed.

This is to fix issues when new configuration did not match old.
Also fix logger of MuonConfig so it can turn CA debugging on

Hello,

This MR is changing the seed jet pt cut from 10 GeV to 0 GeV in the tau reconstruction.
It does not change the reconstruction output, because this cut is set upstream to 15 GeV in the jet reconstruction: https://gitlab.cern.ch/atlas/athena/-/blob/master/Reconstruction/Jet/JetRec/share/JetRec_jobOptions.py#L33.
However, for the R22 reprocessing, we will have to drop this 15 GeV cut from the AntiKt4LCTopo jet reconstruction (by setting jetFlags.useCalibJetThreshold to False), and instead apply a tau pt cut at the end of the tau reconstruction, in the tau thinning algorithm.

Cheers,
Bertrand

Try to fix ATLASRECTS-6027 , Also try to format MuonCreatorTool, run clang-tidy for nullptr, qualified auto etc

Scott Snyder authored 4 years ago and Vakhtang Tsulaia committed 4 years ago

Avoid spurious copies in range-for loops.

Scott Snyder authored 4 years ago and Vakhtang Tsulaia committed 4 years ago

Avoid spurious copy in range-for.

Nils Erik Krumnack authored 4 years ago and Atlas Nightlybuild committed 4 years ago

Adjust JetUncertainties mass-scale accessors to be created where they are used

See merge request atlas/athena!41421

(cherry picked from commit 7c7f931fe0d0bd5b7ca19a9afbedc438ca4dd0ca)

099367ee Initialising accessors where actually used

Hello,

This MR is just a tiny code improvement.
We are selecting the track category with highest probability. Instead of looping over 5 categories, we now loop over 4 categories...
The reconstruction output is unchanged.

Cheers,
Bertrand

Increase slightly the timeout for the TrackParticleTPCnv_16.6.3 test.
It has been timing out frequently in dbg builds.

Adding the inside-out reco to the muon triggers in the new JO test (ATR-20388):

- Add the inside-out reco algorithms to the muon trigger configuration, and run in a sequence only if we don't find any muons in the outside-in reco sequence
- Add the configuration for the algorithms that check for outside-in muons and merges the muon trigger containers
- Update the muon reco config to remove a couple cases of unneeded 'addPublicTools' and to use the correct track summary tool for a given use case (CombinedMuonTrackSummaryTool when looking at combined muons, and the MuonTrackSummaryTool otherwise)

Remove trigger python files from trace excludes that no longer exist.

Johannes Junggeburth authored 4 years ago and Adam Edward Barton committed 4 years ago

Use the ME track particle for hit counting if the MS is not there. This is following the primaryTrackParticle logic dropping the ID track

    
Removing some const_casts from SimpleAmbiguityProcessor.

    
Removing some const_casts from SimpleAmbiguityProcessor.