Change uses of the obsolete LArOFCTool to use the conditions algorithm instead.
Clean up LArOFC2Ntuple a bit.

Denis Oliveira Damazio authored 3 years ago and Adam Edward Barton committed 3 years ago

Preparing C++ and python infrastructure for SC AutoCorrNoise CondAlg to be included in Full Simulation

Fix more instances of python 2 print statements.

Also fix a duplicate porperty declaration.

Pavol Strizenec authored 5 years ago and Frank Winklmeier committed 5 years ago

Adding functionality for supercell calibration data reconstruction

See merge request !1408

Former-commit-id: 14f45f35c42246c1cb224f94cba7cd585b46e491

Pavol Strizenec authored 5 years ago and Edward Moyse committed 5 years ago

Fixes for LAr and Calo calibration tools

See merge request !5148

Former-commit-id: 79cebc99a593be4e73fe18a02901cbb752452cac

Scott Snyder authored 5 years ago and Adam Edward Barton committed 5 years ago

Remove mutable cache in LArFebConfig --- it can't really be making
any significant difference.  But add a method to retrieve both upper
and lower thresholds in one go.  Thus can also remove the locking.
Convert the map to an unordered_map.  Add a method to fill the map,
allowing the removal of the friend declaration.

Fix Gaudi CablingKey property duplicated between base/derived classes.

    
Remove MT-unsafe uses of CaloIdManager.

LArCondUtils: dropped references to EventInfo and moved headers to src. Also fixed two client packages

Pavol Strizenec authored 6 years ago and Frank Winklmeier committed 6 years ago

Former-commit-id: 7447c689

Former-commit-id: d6189b38

major changes:

 - removal of DECLARE_FACTORY_ENTRIES
 - DECLARE_CONVERTER_FACTORY -> DECLARE_CONVERTER
 - DECLARE_TOOL_FACTORY -> DECLARE_COMPONENT
 - DECLARE_SERVICE_FACTORY -> DECLARE_COMPONENT
 - DECLARE_ALGORITHM_FACTORY -> DECLARE_COMPONENT
 - constructor of Converters is public, not protected
 - remove #include "GaudiKernel/CnvFactory.h"
 - remove #include "GaudiKernel/ToolFactory.h"
 - remove #include "GaudiKernel/AlgFactory.h"
 - remove #include "GaudiKernel/AudFactory.h"
 - remove #include "DeclareFactoryEntries.h"


Former-commit-id: fd7a40f5

This reverts commit cdf718bf [formerly 9d67f5b8].


Former-commit-id: 008b62d0

This reverts commit 9156e32a [formerly f73d17d3], reversing
changes made to 27d106d1 [formerly 8f2f5188].


Former-commit-id: 9d67f5b8

Compilation warning: uninitialized variables.



Former-commit-id: 7795360a

Coverity fixes: Potential memory leaks.


Former-commit-id: fe56e403

Make some contructors public as required by the Gaudi Plugin service


Former-commit-id: fc09419a

- Delete all obsolete src/components/*_load.cxx files
- Remove obsolete DECLARE_FACTORY_ENTRIES within
  src/components/*_entries.cxx

The removed macros evaluate to NULL on the Gaudi side and have been
kept only for backwards compatibility.


Former-commit-id: 325d0587

LArPedestals2Ntuple and LArRamps2Ntuples were changed to get their inputs
from the conditions store rather than the detector store.
However, this breaks existing configurations, such as used in
the LArCalibProcessing tests, which still put their outputs 
in the detector store.  Updating these configurations to do everything
in the conditions store is not trivial, especially since some of them
rely on in situ modification of objects in the detector store.
Interactions with conditions writing in RegistrationServices also
needs to be considered.

For the time being, modify these two ntuple classes to look for their
inputs in the detector store first, and only after that in the
conditions store.

Fixes ATN failures in LArCalibProcessing.


Former-commit-id: 409606e1

Former-commit-id: dc226b4f

gcc6 warnings: Inconsistent indentation.



Former-commit-id: 482d864b

endreq is deprecated, and replaced with endmsg.

Did not replace in log files, or READMEs. Two files which are questionable are
   InnerDetector/InDetAlignAlgs/InDetAlignGenAlgs/src/GeoModelTRT.dev
and
   InnerDetector/InDetRecTools/InDetMultipleVertexSeedFinderUtils/src/PVFindingTrackFilter_cxx


Former-commit-id: 699dba0d

	* Tagging LArCalibTools-00-09-60.
	* Cabling tools moved from LArTools to LArCabling.
	* Tagging LArCalibTools-00-09-59.
	* Fix clang warning.
	* Tagging LArCalibTools-00-09-58.
	* Do not use using namespace in a header.
	* Tagging LArCalibTools-00-09-57.
	* Comply with ATLAS naming conventions.

07-12-2015 Pavol Strizenec <pavol @ mail.cern.ch>
	* changes in LArWFParams2Ntuple and LArCommConditions2Ntuple
	* fix in CompletetoFlat for DSPThreshold
	* tag LArCalibTools-00-09-56

2-12-2015 Pavol Strizenec pavol @ mail.cern.ch
	* adding the LArOFCBin algo
	* not tagging yet

2015-08-31 Walter Lampl <walter.lampl@ cern.ch>
...
(Long ChangeLog diff - truncated)

	* Tagging LArCalibTools-00-09-47.
	* Fix coverity warning.

2015-01-11  scott snyder  <snyder@bnl.gov>

	* Tagging LArCalibTools-00-09-46.
	* AthenaBaseComps migration.

2014-11-21 Walter Lampl <walter.lampl@ cern.ch>
	* complete2Flat: Bugfix and better diagnostic message
	* tag LArCalibTools-00-09-45

2014-11-14 Walter Lampl <walter.lampl@ cern.ch>
	* fix include guard of LArDigits2Ntuple
	* tag LArCalibTools-00-09-44

2014-10-31 Walter Lampl <walter.lampl@ cern.ch>
	* LArHVScaleCorr2Ntuple: Use abstract interface ILArHVScaleCorr instead of LArHVScaleCorrComplete
	* LArCommConditions2Ntuple.py: Add HV Scale Correction
...
(Long ChangeLog diff - truncated)