Made the package depend on FFTW, to fulfil a runtime dependency
for RooFFTConvPdf, and also cleaned up the configuration a bit at
the same time.

    
Don't use references in a range-for if the object must be copied.

Andrii Verbytskyi authored 4 years ago and Vakhtang Tsulaia committed 4 years ago

Try to have constcorrect InnerDetector/InDetValidation/InDetRecStatistics/src/InDetRecStatisticsAlg.cxx

New compiler, new set of warnings...

The main theme here is that clang now checks for range-based for loops
whether it introduces unneeded temporaries, i.e. if the user asks for
a reference for the loop variable, but the iterator doesn't return a
reference or a reference of a different type, or conversely if the
user asked for `const auto`, but could have been `const auto&`.

In practice that usually hits us as:
```
for (const auto& jet : jetContainer)
```
which should be:
```
for (const auto *jet : jetContainer)
```

Also a couple of places like this (which miss the `const` qualifier on
the first template parameter):
```
std::map<std::string,std::string> stringMap;
for (const std::pair<std::string,std::string>& stringPair : stringMap)
```

For the most part I just replaced the loop variable type with what
seemed correct.  In a few places I put explicit comments as to why I
chose the type.

Also a fair number of warnings for unused member variables in various
packages.  Since I am not an expert on any of these packages and this
can point to an actual bug, I commented out all unused variables and
added a comment for actual experts to check and remove.

I removed a couple of checks for `this != nullptr` which were
originally introduced to check whether the user called a member
function via a null pointer.  However those checks are `assert`-based,
so with cmake they won't be included when the user calls them from a
release, making this check mostly useless.

There some other warnings I fixed in the process that should hopefully
be self-explanatory.

Enable flake8 and make code compliant. Most of this code is legacy and
where the fixes would have been too numerous/intrusive mark the entire
file with `noqa`. Also delete unused `EFIDUtils.py`.

Don't add PixelHitDiscCnfgAlg if we don't have a HitDiscCnfg folder.
Fixes failure in q222.

Missing override keywords.
Unused private data members.

If a dtor is declared final, then the class itself must also be final.

Don't use fabs() with an integer argument; use std::abs instead.

Jay Ajitbhai Sandesara authored 4 years ago and Walter Lampl committed 4 years ago

Moved from writing ntuple per event to per seed, for seeds seen by the SiSPSeededTrackFinder algorithm.

Missing override keywords.

Missing override keywords.

Distance  solution, move inline to .icc and use default. Also fix SCT_Digitization to used std::log, std::sqrt

Also move other interface includes to main header file.

Calling `setProperties` is deprecated and properties are being set
already in the base class `sysInitialize` method. So there is no need
for this call.

Braces in initializers.

Can't use full template-id as a ctor name.

Missing override keywords.