Susumu Oda authored 4 years ago and Adam Edward Barton committed 4 years ago

Use IDCInDetBSErrContainer for SCT_FlaggedCondData instead of SCT_FlaggedCondData in WriteInDetESD.py

Library dependency fix.

Library dependency fixes.

Library dependency fixes.

Library dependency fixes.

Library dependency fixes.

Library dependency fixes.

Library dependency fixes.

Library dependency fixes.

Currently the InDetTrigExtensProcessor relies on the scoring tool to
create the track summary and store it in the track, which violates
const-ness.

Move the reasons of trhead unsafety to the lines of ATLAS_NOT_THREAD_SAFE or ATLAS_NO_CHECK_FILE_THREAD_SAFETY for easier understanding using LXR and git grep. Remove ATLAS_NOT_THREAD_SAFE from TRT_BSErrContainerCnv_p1::transToPers and TRT_BSErrContainerCnv_p2::transToPers.

Walter Lampl authored 4 years ago and Edward Moyse committed 4 years ago

rename TRT_BSErrContainer into TRT_BSErrContainer_p1 (to serve as persistent version), create new transient TRT_BSErrContainer mimicking the interface of the TRT_ByteStream_ConditionsSvc

Change TrigTrackSlimmer to use the slimCopy() method of ITrackSlimmingTool
rather than slim.

Avoids thread-safety issues.

The thread-safety checker was not properly checking calls to virtual functions.
When that is fixed, we get a warning about the call to
IPRDtoTrackMapExchange::setPRDtoTrackMap.

This is indeed not thread safe, and is supposed to be used only for
backwards compatibility with run 2.

To resolve this, split out the non-thread-safe part into a separate function.
We suppress the thread-safety checker warning in the call to it,
but we also explicitly check and fail the job if we're running
such a run 2 configuration with more than one thread.

Susumu Oda authored 4 years ago and Frank Winklmeier committed 4 years ago

Add using std::abs as protection against missing #include <cmath> when  using namespace std is used.

- Moved mutable members into EventData struct or replaced them by local variables
  which are passed through.
- Made member functions constant.
- Removed remaining magnetic field init callback. Field mode now adjusted per event.
- Removed most stream operators to dump tools. The dump methods which provide the
  actual functionality are still available.

Goetz Gaycken authored 5 years ago and Walter Lampl committed 5 years ago

- Use a PRD-to-track map rather than the PRD_AssociationTool which conains a PRD-to-track map
  internally. This is needed to resolve ATLASRECTS-5005.
- Made all methods const.
- The score processor does not create track copies anymore, thus PRD-to-track maps stay valid for
  scored tracks.
- The ambiguity processors now use a helper class which manages the new and original tracks i.e.
  tracks with mixed ownership, and creates track copies only for the final track collection if
  necessary.
- Moved debug ntuple code of simple ambiguity processor to a new derived class, to improve the
  readability.

Fix path for TrkEventUtils.