Tim Martin authored 4 years ago and Walter Lampl committed 4 years ago

Add 'mayBeRemapped' boolean to TrigComposite link fetching interface, default FALSE (to save CPU). Add link deletion functions.

Bertrand Martin Dit Latour authored 4 years ago and Walter Lampl committed 4 years ago

Hello,

This MR is adding a tau track flag to identify large radius tracks more easily, when LRTs are enabled in the tau reconstruction.
We can now retrieve specifically the LRTs associated with the tau via tau->tracks(xAOD::TauJetParameters::TauTrackFlag::LargeRadiusTrack).
This flag is agnostic w.r.t. the track classification, it is only used to tag LRTs, which will be useful e.g. to count LRTs within 0.4 of the tau axis.

As LRTs are not used by default, this MR does not change the reconstruction output.

Cheers,
Bertrand

Suppress cppcheck syntax error warning.
Apparently arises due to the gtest macros.

xAODCaloEvent::setLink , add method passing EventContext, using the ElementLink ctor with EventContext . Additional to the similar IProxyMethods

    
Don't use references in a range-for if the object must be copied.

    
Don't use references in a range-for if the object must be copied.

William Axel Leight authored 4 years ago and Adam Edward Barton committed 4 years ago

This ensures that the final segment collections written out contain both MuGirl and Muon(Moo)SegmentFinderAlg segments.
The xAOD segment container is now created and filled in the MuonCreatorAlg (so the xAODMuonCnvAlg is removed from the configuration).
The Muon(Moo)SegmentFinderAlg segments are copied into the final Trk::SegmentCollection in MuonCreatorAlg.
Conversion of the segments now happens in the the MuonCreatorAlg as well.
MuGirl segments are only added to the collection if they correspond to a muon with primary author MuGirl.
The MuonSegmentContainer used for associating segments to muons is now passed directly to the tool, rather than retrieved from SG.

    
Don't use references in a range-for if the object must be copied.

Frank Berghaus authored 4 years ago and Walter Lampl committed 4 years ago

Writing the output FileMetaData on preFinalize causes problems in
EventService: event ranges will be written out before the FileMetaData
object is created. This causes an error when the stream is told to write
an object that does not (yet) exist.

Enhancement: make the log messages from the FileMetaDataCreatorTool more
informative.

New compiler, new set of warnings...

The main theme here is that clang now checks for range-based for loops
whether it introduces unneeded temporaries, i.e. if the user asks for
a reference for the loop variable, but the iterator doesn't return a
reference or a reference of a different type, or conversely if the
user asked for `const auto`, but could have been `const auto&`.

In practice that usually hits us as:
```
for (const auto& jet : jetContainer)
```
which should be:
```
for (const auto *jet : jetContainer)
```

Also a couple of places like this (which miss the `const` qualifier on
the first template parameter):
```
std::map<std::string,std::string> stringMap;
for (const std::pair<std::string,std::string>& stringPair : stringMap)
```

For the most part I just replaced the loop variable type with what
seemed correct.  In a few places I put explicit comments as to why I
chose the type.

Also a fair number of warnings for unused member variables in various
packages.  Since I am not an expert on any of these packages and this
can point to an actual bug, I commented out all unused variables and
added a comment for actual experts to check and remove.

I removed a couple of checks for `this != nullptr` which were
originally introduced to check whether the user called a member
function via a null pointer.  However those checks are `assert`-based,
so with cmake they won't be included when the user calls them from a
release, making this check mostly useless.

There some other warnings I fixed in the process that should hopefully
be self-explanatory.

Hello,

This MR is mostly importing !26767 from 21.2 to master, with the original MR description pasted below.

A protection is added against invalid TauTrack links when retrieving the tau tracks or the number of tau tracks.
This is required to support tau track thinning, used e.g. in DAOD_PHYS.
Now, only the tau tracks that have a valid link are considered in the TauJets interface class.
In particular, the behaviour of nAllTracks() had to be changed to be consistent with allTracks().size().
If one only keeps e.g. classifiedCharged tau tracks by thinning away the other tracks, nAllTracks() will now return the number of classifiedCharged tracks.

Something new compared to the R21 MR: to keep track of the total number of tracks associated with the tau in the reconstruction, a new Aux variable is introduced (mapped to xAOD::TauJetParameters::nAllTracks). So the user is now able to tell if tracks were thinned in the AOD->DAOD step, by comparing tau->nAllTracks() to tau->detail(xAOD::TauJetParameters::nAllTracks, nTracksTot).

Cheers,
Bertrand

ROOT-10940 is hitting the AthAnalysis projects in this test, unlike
all the other projects weirdly enough.

At the same time also disabled some of the tests completely, as they
do not work correctly with the reduced EDM provided by AthAnalysis.

All clients will need to set this flag of EventInfoCnvAlgCfg(...) correctly
from now on, otherwise they'll get an import error if they used an incorrect
setting in one of the lightweight offline releases.